Dan Kenigsberg has posted comments on this change.
Change subject: Try to destroy VM gracefully ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
.................................................... File vdsm/libvirtvm.py Line 1864: time.sleep(30) I believe that Engine would not be able to accommodate such a change in semantics. It expects the Vm to be dead when destroy() returns successfully.
Sleeping for a hardcoded 30 seconds is ugly (but less dangerous than the 2 seconds' sleep virDomainDestory(UNGRACEFULL) gives us.
-- To view, visit http://gerrit.ovirt.org/2138 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If58f1b0e7208242aef0b81d9ea59d05bd3d5d99e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com