Wenyi Gao has posted comments on this change.
Change subject: Make safer to get vdsm section version in configuration files ......................................................................
Patch Set 1: No score
Hi Douglas, thanks for your comments. Currently, the version number is 4.9.6. We only search the number "4.9.6" to decide if the vdsm section is in configuration files. If configuration files happen to have the same number, we will get something wrong. In the feature, the version number may be 6.0 or something else that is a simple number. I think it is always a potential problem.
-- To view, visit http://gerrit.ovirt.org/5051 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I947522f6a819ecd4ea62747b42d79e11b65543af Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenyi Gao wenyi@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Wenyi Gao wenyi@linux.vnet.ibm.com