Dan Kenigsberg has posted comments on this change.
Change subject: call stop_event_loop upon exit ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/26532/1/vdsm/vdsm File vdsm/vdsm:
Line 80: while running[0]: Line 81: signal.pause() Line 82: finally: Line 83: cif.prepareForShutdown() Line 84: libvirtconnection.stop_event_loop()
not better to put it before the call to prepareForShutdown that can stuck ?
I don't really understand why this would be any better.
It's nicer to call stop() in the opposite order of calling start (and hence I should take my stop() call out of the finally block. Line 85: Line 86: Line 87: def run(pidfile=None): Line 88: lconfig.fileConfig(loggerConfFile, disable_existing_loggers=False)