Bala.FA has posted comments on this change.
Change subject: gluster: add server uuid into volume brick info list ......................................................................
Patch Set 1: Code-Review-1
(2 comments)
.................................................... Commit Message Line 11: If we get the host uuid along with other brick details in volume info Line 12: command it will be easy for ovirt-engine to find out the Line 13: server and thereby we can avoid confusion in finding the server. Line 14: Line 15: This patch provides volume brick uuid for a given brick Does this patch provide host uuid ie glusterd uuid or brick uuid? Line 16: Line 17: Change-Id: I0e33f9baf50f66f6120545c25b0a01a7c3b75d17
.................................................... File vdsm/gluster/cli.py Line 348: value['bricksUuid'] = [] Line 349: value['options'] = {} Line 350: for b in el.findall('bricks/brick'): Line 351: value['bricks'].append(b.text) Line 352: value['bricksUuid'] += [c[1] for c in b.items() if c[0] == 'uuid'] Why can't you get the uuid driectly than looping using find/findall? Is it required to have uuid/brick mapping? Line 353: for o in el.findall('options/option'): Line 354: value['options'][o.find('name').text] = o.find('value').text Line 355: volumes[value['volumeName']] = value Line 356: return volumes