Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Move vdsmd.init to vdsm-tool ......................................................................
Patch Set 4: (5 inline comments)
Partial review
.................................................... File vdsm-tool/vdsmd.py Line 306: This fucntion test if the "/sbin/initctl" can be executed. s/fucntion/function
Line 475: ssl == 'true'): I quite like to use all in these cases, and move the safest comparisons to the front.
if (ssl == 'true' and all(map(os.path.exists, (cacertpath, vdsmcertpath, vdsmkeypath)))):
or
if (ssl == 'true' and all(os.path.exists(p) for p in (cacertpath, vdsmcertpath, vdsmkeypath))):
Line 562: Stop libvirt SysV service if we intend to configure upstart Bit inconsistent indenting here.
Line 565: if(_upstart_libvirt()): No need for the enclosing parenthesis.
Line 749: _reconfigure(False) I was always taught to write this as:
_reconfigure(args == 'force')
-- To view, visit http://gerrit.ovirt.org/4738 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I52db67207532ac7ded51cdd8c5dc388e85629104 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenyi Gao wenyi@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Wenyi Gao wenyi@linux.vnet.ibm.com