From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: introduce pylint check ......................................................................
Patch Set 10:
(1 comment)
can you rebase on top of master, so we do not need to wait for the two pending pylint patches?
https://gerrit.ovirt.org/#/c/69345/10/tox.ini File tox.ini:
Line 34: PYTHONPATH = vdsm:lib Line 35: deps = Line 36: pylint==1.6.4 Line 37: commands = Line 38: pylint --errors-only storage virt vdsm yajsonrpc vdsmclient don't you need to explicitly list vdsm/*.py (since they are not in any python package)?
I mean, are you sure you see errors from these files? Line 39: Line 40: [testenv:flake8] Line 41: deps = Line 42: flake8==3.0.4