Alon Bar-Lev has posted comments on this change.
Change subject: setup: move the certificate generation ......................................................................
Patch Set 2:
1. I personally don't like leftovers as the iterative creation of a->b->c may lead to c always fails if b is a bad resource. Creating the whole chain upon failure has higher chance to success, as this is the atomic transaction we need, either to succeed or fail. But I won't make life harder in this regard.
2. As far as I know ssh keys are persisted. Not sure at which point. But I don't get invalid key when rebooting.
-- To view, visit http://gerrit.ovirt.org/8368 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I40fa3d9a6a54e312e399af3f87ac67e843078360 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com