Royce Lv has posted comments on this change.
Change subject: [WIP]change startup process for vdsm and supervdsm ......................................................................
Patch Set 4: (1 inline comment)
I think the two failure you tested is because I should kill then start vdsm instead just start vdsm.
.................................................... File vdsm/supervdsm.py Line 53: os.unlink(ADDRESS) After a second thought, I think if svdsm is killed and not clean this ADDRESS, but in the startup period, vdsm is started prior to svdsm, and if it doesn't clean ADDR, it will raise "address already in use" error, so it is necessary.
-- To view, visit http://gerrit.ovirt.org/4145 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I69aae6b0b9529c80291d90c6ad14ff82b21aea53 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Wenyi Gao wenyi@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com