Dan Kenigsberg has posted comments on this change.
Change subject: setup: move the certificate generation ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(3 inline comments)
I'd rather have vdsmd have a single call to
vdsm-gencert.sh --interactive
(or whatever) so that a future port to vdsm-tool is clearer.
.................................................... Commit Message Line 13: first time. Line 14: Line 15: In this patch: Line 16: * Move the certificate generation from the spec file to the init file Line 17: * Refactor and improve the vdsm-gencerts script (better error handling) combining these two changes in one commit makes my head spin. Line 18: Line 19: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=860067 Line 20: Signed-off-by: Federico Simoncelli fsimonce@redhat.com
.................................................... File vdsm/vdsmd.init.in Line 21: # Short-Description: init script for the VDS management server Line 22: ### END INIT INFO Line 23: Line 24: . @LIBEXECDIR@/ovirt_functions.sh Line 25: . @LIBEXECDIR@/vdsm-gencerts.sh --sh-import We would like to take code OUT of this over-grown script. Not source more functions into it... this whole things looks like a task for vdsm-tool. But let's first solve the current bug. Line 26: Line 27: VDSM_BIN=@VDSMDIR@/vdsm Line 28: CONF_FILE=@CONFDIR@/vdsm.conf Line 29: GETCONFITEM=@VDSMDIR@/get-conf-item
Line 450: Line 451: shutdown_conflicting_srv && stop_libvirtd_sysv Line 452: Line 453: if ! vdsm_check_certificate; then Line 454: echo -n $"Configuring the VDSM host certificate: " the string here should be more specific, making clear that this is a stupid self-signed certificate, made for local usage only. How about
Configuring a self-signed VDSM host certificate: Line 455: (vdsm_create_key && vdsm_create_ca && vdsm_create_cert) \ Line 456: && success || failure; echo Line 457: fi Line 458:
-- To view, visit http://gerrit.ovirt.org/8368 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I40fa3d9a6a54e312e399af3f87ac67e843078360 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Michael Burns mburns@redhat.com