Dan Kenigsberg has submitted this change and it was merged.
Change subject: call stop_event_loop upon exit ......................................................................
call stop_event_loop upon exit
For cleanliness, whomever starts a thread should stop it when it is no longer needed.
We add a "wait" argument to stop_event_loop, so that the calling serve_clients() does not wait forever for a libvirt event to be handled.
Change-Id: I9ab0d9b7be976e37a89a96d2f09a353186008731 Signed-off-by: Dan Kenigsberg danken@redhat.com Reviewed-on: https://gerrit.ovirt.org/26532 Reviewed-by: Nir Soffer nsoffer@redhat.com Reviewed-by: Francesco Romani fromani@redhat.com Tested-by: Francesco Romani fromani@redhat.com --- M lib/vdsm/libvirtconnection.py M vdsm/vdsm 2 files changed, 23 insertions(+), 20 deletions(-)
Approvals: Nir Soffer: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved; Passed CI tests Francesco Romani: Verified; Looks good to me, but someone else must approve