Dan Kenigsberg has posted comments on this change.
Change subject: xmlrpc: Parsing error logging enhancement - vdsClient
......................................................................
Patch Set 3: Code-Review-1
(2 comments)
....................................................
Commit Message
Line 5: CommitDate: 2013-11-04 09:44:48 +0100
Line 6:
Line 7: xmlrpc: Parsing error logging enhancement - vdsClient
Line 8:
Line 9: Logging enhancement which help to understand the issues during
English mistake stays. You should say "which helps understand the issues..."
Line 10: parsing xml response obtained from vdsm. Parsing
Line 11: issues can occur when bad characters are in xml etc.
Line 12:
Line 13: In order to get raw response we need to wrap transport class
....................................................
File lib/vdsm/vdscli.py.in
Line 40:
Line 41: def __getattr__(self, name):
Line 42: if hasattr(self._transport, name):
Line 43: func = getattr(self._transport, name)
Line 44: return lambda *args, **kwargs: self._wrap(name, func, args, kwargs)
Please answer: which method(s) is(are) expected to raise ExpatError? I'd rather be more specific and wrap only the thing we need.
Line 45: raise AttributeError(name)
Line 46:
Line 47: def _wrap(self, name, func, args, kwargs):
Line 48: try:
--
To view, visit http://gerrit.ovirt.org/20627
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife29c4f7749b9cd8a4ad892f486d91509e505ae4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
Dan Kenigsberg has uploaded a new change for review.
Change subject: libvirt is happy with redefinition of an existing nwfilter
......................................................................
libvirt is happy with redefinition of an existing nwfilter
Change-Id: Id253c66df8296613b6a2bc3fc058ef2754702964
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/tool/nwfilter.py
1 file changed, 0 insertions(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/20788/1
diff --git a/lib/vdsm/tool/nwfilter.py b/lib/vdsm/tool/nwfilter.py
index 54bbe8d..f87f975 100755
--- a/lib/vdsm/tool/nwfilter.py
+++ b/lib/vdsm/tool/nwfilter.py
@@ -56,14 +56,6 @@
define vdsm network filter on libvirt to control VM traffic
"""
- try:
- conn.nwfilterLookupByName(self.filterName).undefine()
- except libvirt.libvirtError:
- # Ignore failure if filter isn't exists or if failed to remove.
- # Failure might occur when attempting to remove a filter which
- # is being used by running VMs
- pass
-
nwFilter = conn.nwfilterDefineXML(self.buildFilterXml())
logging.debug("Filter %s was defined" % nwFilter.name())
--
To view, visit http://gerrit.ovirt.org/20788
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id253c66df8296613b6a2bc3fc058ef2754702964
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Nir Soffer has posted comments on this change.
Change subject: tests: prevent hook validation decorator from leaving scripts installed
......................................................................
Patch Set 7:
(1 comment)
....................................................
File lib/vdsm/utils.py
Line 130: logging.warning("Directory: %s already removed", directoryToRemove)
Line 131: else:
Line 132: logging.error("Removing directory: %s failed", directoryToRemove,
Line 133: exc_info=True)
Line 134: raise
We have similar saying about acting like roman in Rome :-) That is a valid reason.
I'll let others approve this.
Line 135:
Line 136: IPXMLRPCRequestHandler = SimpleXMLRPCRequestHandler
Line 137:
Line 138:
--
To view, visit http://gerrit.ovirt.org/20310
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I138c3eab77ea6d35d6a997049940923026e06d96
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes