Hi,All
The patch is to correct the variable name from VDSM-BIN to VDSM-REG-BIN in vdsm-reg script.
--- vdsm/vdsm_reg/vdsm-reg 2011-11-07 10:14:13.755603162 +0800 +++ vdsm/vdsm_reg/vdsm-reg.new 2011-11-07 10:15:15.925603172 +0800 @@ -22,7 +22,7 @@ start() { echo "vdsm-reg: starting"
- pid=`pidofproc -p $PIDFILE $VDSM_BIN` + pid=`pidofproc -p $PIDFILE $VDSM_REG_BIN` RETVAL=$? if [ "$RETVAL" -eq 0 ]; then log_failure_msg "$prog: already running"
On Mon, Nov 07, 2011 at 10:53:00AM +0800, Jarod. w wrote:
Hi,All
The patch is to correct the variable name from VDSM-BIN to VDSM-REG-BIN
in vdsm-reg script.
--- vdsm/vdsm_reg/vdsm-reg 2011-11-07 10:14:13.755603162 +0800 +++ vdsm/vdsm_reg/vdsm-reg.new 2011-11-07 10:15:15.925603172 +0800 @@ -22,7 +22,7 @@ start() { echo "vdsm-reg: starting"
- pid=`pidofproc -p $PIDFILE $VDSM_BIN`
- pid=`pidofproc -p $PIDFILE $VDSM_REG_BIN` RETVAL=$? if [ "$RETVAL" -eq 0 ]; then log_failure_msg "$prog: already running"
Thanks. The patch is correct, but in the future please send the whole output of `git format-patch` to make it easier on me to apply.
Does this patch solve an actual problem you are facing, or that you noticed it by simply browsing the code?
Regards, Dan.
Sure...I will send the whole output of the command next time. I noticed it by browsing the code.
2011/11/8 Dan Kenigsberg danken@redhat.com
On Mon, Nov 07, 2011 at 10:53:00AM +0800, Jarod. w wrote:
Hi,All
The patch is to correct the variable name from VDSM-BIN to
VDSM-REG-BIN
in vdsm-reg script.
--- vdsm/vdsm_reg/vdsm-reg 2011-11-07 10:14:13.755603162 +0800 +++ vdsm/vdsm_reg/vdsm-reg.new 2011-11-07 10:15:15.925603172 +0800 @@ -22,7 +22,7 @@ start() { echo "vdsm-reg: starting"
- pid=`pidofproc -p $PIDFILE $VDSM_BIN`
- pid=`pidofproc -p $PIDFILE $VDSM_REG_BIN` RETVAL=$? if [ "$RETVAL" -eq 0 ]; then log_failure_msg "$prog: already running"
Thanks. The patch is correct, but in the future please send the whole output of `git format-patch` to make it easier on me to apply.
Does this patch solve an actual problem you are facing, or that you noticed it by simply browsing the code?
Regards, Dan.
vdsm-devel@lists.fedorahosted.org