I just finished a version of my git-request-review script.
For those who are not yet using it it's meant to make sending patches to gerrit more streamlined. It show you a list of the patches before sending them and also warns you if you are not rebased.
To have it working you need to have a configured remote for gerrit already in your git config In order for git to detect it as a new verb you have to have this in your path
usage: git request-review <gerrit-remote> <remote-branch>
eg. git request-review gerrit master
For those of you who are using the old version will probably notice this version forgoes special gerrit configuration and can support multiple gerrit servers (just configure more remotes).
Fixes, features and comments are always welcome.
Happy reviewing.
On Thu, Nov 10, 2011 at 11:51:06AM +0200, Saggi Mizrahi wrote:
I just finished a version of my git-request-review script.
For those who are not yet using it it's meant to make sending patches to gerrit more streamlined. It show you a list of the patches before sending them and also warns you if you are not rebased.
To have it working you need to have a configured remote for gerrit already in your git config In order for git to detect it as a new verb you have to have this in your path
usage: git request-review <gerrit-remote> <remote-branch>
eg. git request-review gerrit master
For those of you who are using the old version will probably notice this version forgoes special gerrit configuration and can support multiple gerrit servers (just configure more remotes).
Fixes, features and comments are always welcome.
Happy reviewing.
#!/bin/bash # # Copyright 2011 Saggi Mizrahi smizrahi@redhat.com # # Licensed to you under the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or # (at your option) any later version. See the files README and # LICENSE_GPL_v2 which accompany this distribution.
Nothing accompanies your script! Better don't mention it.
#
if [ -z $2 ]; then
here, and everywhere, unquoted bash variable is a syntax error waiting to happen. if you go over and fix it, better use names for $1 $2.
echo "usage: git request-review <gerrit-remote> <remote-branch>" exit 1
wouldn't it be nicer to have a config bit for default gerrit-remote? most people are going to have only one.
fi
Thanks Saggi for your script, I use it daily.
Dan.
Dear developers,
I'm pleased to inform you that Vdsm is now a member project of gerrit.ovirt.org. You can see it in http://gerrit.ovirt.org/gitweb?p=vdsm.git and clone it from http://gerrit.ovirt.org/p/vdsm.git.
The (prefered) way to submit patches is to get yourself a gerrit account, define a "git remote" similar to
[remote "ovirt"] url = http://gerrit.ovirt.org/p/vdsm pushurl = ssh://<your-username>@gerrit.ovirt.org:29418/vdsm fetch = +refs/heads/*:refs/remotes/ovirt/*
rebase your contribution over ovirt/master branch, use Saggi's git-request-review ovirt master and wait for Acks.
Now Acks do not come out of thin air... http://gerrit.ovirt.org/#q,status:open+project:vdsm,n,z shows all Vdsm patches, waiting for your review. Be a sport, share your opinion.
The Fedora-hosted git repository is hereby obsoleted. Red Hat developers who have pending patches in the in-doors gerrit instance, would have to post them again in the open (sorry folks... this includes me...).
Enjoy,
Dan.
-----Original Message----- From: vdsm-devel-bounces@lists.fedorahosted.org [mailto:vdsm-devel-bounces@lists.fedorahosted.org] On Behalf Of Dan Kenigsberg Sent: Monday, November 14, 2011 0:01 AM To: VDSM Project Development Subject: Upstream gerrit.ovirt.org
Dear developers,
I'm pleased to inform you that Vdsm is now a member project of gerrit.ovirt.org. You can see it in http://gerrit.ovirt.org/gitweb?p=vdsm.git and clone it from http://gerrit.ovirt.org/p/vdsm.git.
The (prefered) way to submit patches is to get yourself a gerrit account, define a "git remote" similar to
Read this wiki with s/ovirt-engine/vdsm/ ? http://www.ovirt.org/wiki/Working_with_oVirt_Gerrit
btw, gitweb is available at: http://gerrit.ovirt.org/gitweb?p=vdsm.git
[remote "ovirt"] url = http://gerrit.ovirt.org/p/vdsm pushurl = ssh://<your-username>@gerrit.ovirt.org:29418/vdsm fetch = +refs/heads/*:refs/remotes/ovirt/*
rebase your contribution over ovirt/master branch, use Saggi's git-request-review ovirt master and wait for Acks.
Now Acks do not come out of thin air... http://gerrit.ovirt.org/#q,status:open+project:vdsm,n,z shows all Vdsm patches, waiting for your review. Be a sport, share your opinion.
The Fedora-hosted git repository is hereby obsoleted. Red Hat developers who have pending patches in the in-doors gerrit instance, would have to post them again in the open (sorry folks... this includes me...).
Enjoy,
Dan. _______________________________________________ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
On 11/10/2011 11:51 AM, Saggi Mizrahi wrote:
I just finished a version of my git-request-review script.
how about a wiki page with this and the script as a file attachment, linked from here? http://www.ovirt.org/wiki/Working_with_oVirt_Gerrit
For those who are not yet using it it's meant to make sending patches to gerrit more streamlined. It show you a list of the patches before sending them and also warns you if you are not rebased.
To have it working you need to have a configured remote for gerrit already in your git config In order for git to detect it as a new verb you have to have this in your path
usage: git request-review <gerrit-remote> <remote-branch>
eg. git request-review gerrit master
For those of you who are using the old version will probably notice this version forgoes special gerrit configuration and can support multiple gerrit servers (just configure more remotes).
Fixes, features and comments are always welcome.
Happy reviewing.
vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
On Wed, Nov 16, 2011 at 12:55 AM, Itamar Heim iheim@redhat.com wrote:
On 11/10/2011 11:51 AM, Saggi Mizrahi wrote:
I just finished a version of my git-request-review script.
how about a wiki page with this and the script as a file attachment, linked from here? http://www.ovirt.org/wiki/Working_with_oVirt_Gerrit
For those who are not yet using it it's meant to make sending patches to gerrit more streamlined.
Have you looked at https://github.com/openstack-ci/git-review ? If nothing else, it might give us ideas how to optimize workflow with Gerrit. Openstack's flow is described in http://wiki.openstack.org/GerritWorkflow
Alan
On Wed 16 Nov 2011 02:39:06 AM IST, Alan Pevec wrote:
On Wed, Nov 16, 2011 at 12:55 AM, Itamar Heimiheim@redhat.com wrote:
On 11/10/2011 11:51 AM, Saggi Mizrahi wrote:
I just finished a version of my git-request-review script.
how about a wiki page with this and the script as a file attachment, linked from here? http://www.ovirt.org/wiki/Working_with_oVirt_Gerrit
For those who are not yet using it it's meant to make sending patches to gerrit more streamlined.
Have you looked at https://github.com/openstack-ci/git-review ? If nothing else, it might give us ideas how to optimize workflow with Gerrit. Openstack's flow is described in http://wiki.openstack.org/GerritWorkflow
Alan
The open-stack scripts are superior and there is no reason not to join forces. I just switched to using them. I had issues with the output so If you like colors and branch\tag names in your output you can use the branch I posted for pull request. https://github.com/openstack-ci/git-review/pull/2
On Thu, 2011-11-10 at 11:51 +0200, Saggi Mizrahi wrote:
I just finished a version of my git-request-review script.
For those who are not yet using it it's meant to make sending patches to gerrit more streamlined. It show you a list of the patches before sending them and also warns you if you are not rebased.
To have it working you need to have a configured remote for gerrit already in your git config In order for git to detect it as a new verb you have to have this in your path
usage: git request-review <gerrit-remote> <remote-branch>
eg. git request-review gerrit master
For those of you who are using the old version will probably notice this version forgoes special gerrit configuration and can support multiple gerrit servers (just configure more remotes).
Fixes, features and comments are always welcome.
Happy reviewing.
Very nice. Copying node-devel as well. This is much more convenient than manually typing the push command.
Mike
Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
vdsm-devel@lists.fedorahosted.org