On Mon, Jul 16, 2012 at 11:34:34AM -0400, Saggi Mizrahi wrote:
Hi, I would just like to push a few notes to people modifying
autoconf\automake lists
Please make sure the lists are sorted. Sorted lists are easier to skim and modify.
Also, unsorted lists are known to make Federico sad, and we all want to keep him happy
because he is a pretty swell guy and the one that we actually have to thank for the
amazing build system.
Also please make sure to add the $(NULL) item so when auto sorting you don't need to
check if you need to add\remove a backslash.
VARIABLE = \
A \
B \
C \
$(NULL)
Ooh, $(NULL) is a cool trick. I've had my share of broken ovirt/master
due to a bad rebase leading to a trailing backslash.
If you are using vim you could just mark all the lines an run ":<>!sort"
to sort.
Also, when adding a file to the PEP_WHITELIST, check if you can just mark the entire
directory instead of the individual file.
Remember, cleanliness is next to godliness.
_______________________________________________
vdsm-devel mailing list
vdsm-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-devel