If you already in the fix scope, i think this part should move to lib/vdsm/tool/configurator.py and we can call it from spec if required
the administrator might use it to check configurations and set them
----- Original Message -----
From: "Sandro Bonazzola" sbonazzo@redhat.com To: "Dan Kenigsberg" danken@redhat.com, dougsland@redhat.com Cc: "vdsm-devel" vdsm-devel@fedorahosted.org Sent: Tuesday, November 12, 2013 11:33:24 AM Subject: Re: [vdsm] /etc/sysctl.d/vdsm
Il 12/11/2013 09:36, Dan Kenigsberg ha scritto:
On Tue, Nov 12, 2013 at 08:00:44AM +0100, Sandro Bonazzola wrote:
Hi On Fedora 19 I can see /etc/sysctl.d/vdsm but it seems that it's not read because it should be /etc/sysctl.d/vdsm.conf ( see sysctl --system output ) Is that file really needed?
It is, according to
Bug 740887 - Tune dirty_ratio and dirty_background_ratio
and it seems to have been broken by commit c737fa2 Replace configure_sysctl with /etc/sysctl.d/vdsm quite a long time ago.
Douglas, Sandro, anyone: could you address this?
It seems that this affects only Fedora since on RHEL and probably CentOS sysctl doesn't support --system and init just read everything in /etc/sysctl.d.
So I'll open a bug against vdsm on oVirt and I'll push the fix for the renaming.
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com _______________________________________________ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel