On Wed, May 30, 2012 at 05:26:47PM +0200, David Jaša wrote:
Do I get it right that host-side of MOM communicates with guest side over network interface? If so, why isn't it following best practices of qemu/kvm world and why it doesn't communicate over its own virtio-serial port?
No that is not correct for oVirt's usage of MOM. MOM has several ways of acquiring guest statistics: Client/server over TCP, libvirt (via. virDomainMemoryStats), qemu-ga (client/server over virtio-serial), etc. For vdsm, memory stats are acquired via the vdsm api itself (API.py:VM.getStats()). VDSM acquires these stats via the ovirt-guest-agent over virto-serial.
David
Mark Wu píše v St 30. 05. 2012 v 22:49 +0800:
Hi Guys,
Recently, I has been working on integrate MOM into VDSM. MOM needs to use VDSM API to interact with it. But currently, it requires the instance of clientIF to use vdsm API. Passing clientIF to MOM is not a good choice since it's a vdsm internal object. So I try to remove the parameter 'cif' from the interface definition and change to access the globally unique clientIF instance in API.py.
To get the instance of clientIF, I add a decorator to clientIF to change it into singleton. Actually, clientIF has been working as a global single instance already. We just don't have an interface to get it and so passing it as parameter instead. I think using singleton to get the instance of clientIF is more clean.
Dan and Saggi already gave some comments in http://gerrit.ovirt.org/#change,4839 Thanks for the reviewing! But I think we need more discussion on it, so I post it here because gerrit is not the appropriate to discuss a design issue.
Thanks ! Mark.
vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
--
David Jaša, RHCE
SPICE QE based in Brno GPG Key: 22C33E24 Fingerprint: 513A 060B D1B4 2A72 7F0D 0278 B125 CD00 22C3 3E24
vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel