----- Original Message -----
From: "Yedidyah Bar David" didi@redhat.com To: "Antoni Segura Puimedon" asegurap@redhat.com Cc: "vdsm-devel" vdsm-devel@fedorahosted.org, "Alon Bar-Lev" alonbl@redhat.com, "Sandro Bonazzola" sbonazzo@redhat.com Sent: Wednesday, November 27, 2013 11:18:39 AM Subject: Re: addNetwork to use existing nic conf
----- Original Message -----
From: "Antoni Segura Puimedon" asegurap@redhat.com To: "Yedidyah Bar David" didi@redhat.com Cc: "vdsm-devel" vdsm-devel@fedorahosted.org, "Alon Bar-Lev" alonbl@redhat.com, "Sandro Bonazzola" sbonazzo@redhat.com Sent: Wednesday, November 27, 2013 11:52:51 AM Subject: Re: addNetwork to use existing nic conf
----- Original Message -----
From: "Yedidyah Bar David" didi@redhat.com To: "vdsm-devel" vdsm-devel@fedorahosted.org Cc: "Alon Bar-Lev" alonbl@redhat.com, "Sandro Bonazzola" sbonazzo@redhat.com, "Antoni Segura Puimedon" asegurap@redhat.com Sent: Wednesday, November 27, 2013 10:38:54 AM Subject: addNetwork to use existing nic conf
Hi all,
While looking at [1], and reading the source of bridge.py of ovirt-hosted-engine-setup and of ovirt-host-deploy, I think the correct thing will be for addNetwork to not require either bootproto=dhcp or ipaddr/netmask/etc., but to take this from the existing conf of the nics to be put inside the bridge.
You mean the addNetwork in vdsm/vdsm/configNetwork.py?
We currently use vdsClient - 'vdsClient addNetwork'.
If that is the case I would very much prefer not to make such change, since that would make addNetwork even farther from referential transparency.
What I propose is that the calling code will use the new getBootProto introduced in: http://gerrit.ovirt.org/18484 (already merged).
Does vdsClient support that?
Well, vdsClient getVdsCaps returns the cfg information for all the devices, part of that will be the bootproto if it is defined on the ifcfg file of the device.
-- Didi