On Wed, Oct 10, 2012 at 03:44:24PM -0400, Andrew Cathrow wrote:
----- Original Message -----
From: "Yaniv Kaul" ykaul@redhat.com To: "Igor Lvovsky" ilvovsky@redhat.com Cc: "Dan Yasny" dyasny@redhat.com, "engine-devel" engine-devel@ovirt.org, "vdsm-devel" vdsm-devel@lists.fedorahosted.org Sent: Wednesday, October 10, 2012 10:53:19 AM Subject: Re: [Engine-devel] Network related hooks in vdsm
On 10/10/2012 04:47 PM, Igor Lvovsky wrote:
Hi everyone, As you know vdsm has hooks mechanism and we already support dozen of hooks for different needs. Now it's a network's time. We would like to get your comments regarding our proposition for network related hooks.
In general we are planning to prepare framework for future support of bunch network related hooks. Some of them already proposed by Itzik Brown [1] and Dan Yasny [2].
Below you can find the additional hooks list that we propose:
Note: In the first stage we can implement these hooks without any parameters, just to provide an entry point for simple hooks.
Networks manipulation:
- before_add_network(conf={}, customProperty={})
- after_add_network(conf={}, customProperty={})
- before_del_network(conf={}, customProperty={})
- after_del_network(conf={}, customProperty={})
- before_edit_network(conf={}, customProperty={})
- after_edit_network(conf={}, customProperty={})
- TBD
Bondings manipulations:
Bond might be interesting because it may require switch configuration
but so will VLAN changes, so perhaps triggers in VLAN changes are worthwhile as well. Y.
- before_add_bond(conf={}, customProperty={})
- after_add_bond(conf={}, customProperty={})
- before_del_bond(conf={}, customProperty={})
- after_del_bond(conf={}, customProperty={})
- before_edit_bond(conf={}, customProperty={})
- after_edit_bond(conf={}, customProperty={})
- TBD
General purpose:
- before_persist_network
- after_persist_network
What about some way of doing a push that's not tied to an event - if we want to "push" something
Would you elaborate on that? I don't understand the English.
Are you looking for a hook that is not tied to a specific network, rather a before_setupnetworks/after_setupnetworks ?
Dan.