* Mark Wu wudxw@linux.vnet.ibm.com [2012-09-07 05:00]:
Mark Wu has posted comments on this change.
Change subject: report cpuUser and cpuSys separately ......................................................................
Patch Set 1:
Here's the cpustats of a running vm:
virsh # cpu-stats 3 CPU0: cpu_time 152.626922854 seconds CPU1: cpu_time 460.343462849 seconds CPU2: cpu_time 37.569566994 seconds CPU3: cpu_time 21.092908393 seconds Total: cpu_time 671.632861090 seconds user_time 3.440000000 seconds system_time 18.380000000 seconds
You can see cpu_time is much bigger than the sum of user_time and system_time, because the guest time is not reported here. So most cpu time is used to run guest code. It makes sense! For a qemu-kvm process, user_time represents the time used by qemu, and system_time represents the time used by kvm module, which doesn't contain guest time. I am not sure if this is what you expect. It could be a little bit confusing for user.
I think it's useful to split the data out seperately for debugging purposes, not clear to me that the user is interested in the break down. Advanced performance tuning will definitely want to observe the data as well as users looking to debug issues.
I don't see the harm in adding additional information.
-- To view, visit http://gerrit.ovirt.org/7718 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I663ad25ff3ff5ce426b5159b6c9a65b7f5167605 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak lhornyak@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Laszlo Hornyak lhornyak@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
vdsm-devel@lists.fedorahosted.org