Since I've taken http://gerrit.ovirt.org/5093 Properly parse configurations in function "do_create" in vdsClient Jenkins's unit tests jobs are failing. See http://jenkins.ovirt.org/job/vdsm_unit_tests/242/console
The reason is that `make check` does not create vdsm_cli/vdscli.py out of vdsm_cli/vdscli.py.in.
Manually, things can be worked-around with make vdsm_cli/vdscli.py
Could you try to fix automake so plain `make check` works? I would not like to revert the patch just for that.
Regards, Dan.
Hi,
I will look into the problem. The build system is a bit complicated for me. Will try best.
@shaohe feng: Could you give me any advice on this problem?
on 06/28/2012 16:05, Dan Kenigsberg wrote:
Since I've taken http://gerrit.ovirt.org/5093 Properly parse configurations in function "do_create" in vdsClient Jenkins's unit tests jobs are failing. See http://jenkins.ovirt.org/job/vdsm_unit_tests/242/console
The reason is that `make check` does not create vdsm_cli/vdscli.py out of vdsm_cli/vdscli.py.in.
Manually, things can be worked-around with make vdsm_cli/vdscli.py
Could you try to fix automake so plain `make check` works? I would not like to revert the patch just for that.
Regards, Dan.
Hi,
I submit a fix at http://gerrit.ovirt.org/5765
on 06/28/2012 16:38, Zhou Zheng Sheng wrote:
Hi,
I will look into the problem. The build system is a bit complicated for me. Will try best.
@shaohe feng: Could you give me any advice on this problem?
on 06/28/2012 16:05, Dan Kenigsberg wrote:
Since I've taken http://gerrit.ovirt.org/5093 Properly parse configurations in function "do_create" in vdsClient Jenkins's unit tests jobs are failing. See http://jenkins.ovirt.org/job/vdsm_unit_tests/242/console
The reason is that `make check` does not create vdsm_cli/vdscli.py out of vdsm_cli/vdscli.py.in.
Manually, things can be worked-around with make vdsm_cli/vdscli.py
Could you try to fix automake so plain `make check` works? I would not like to revert the patch just for that.
Regards, Dan.
On Thu, Jun 28, 2012 at 05:36:22PM +0800, Zhou Zheng Sheng wrote:
Hi,
I submit a fix at http://gerrit.ovirt.org/5765
Thanks for the quick fix! Taken. I suppose we should clean up those .pyc files on `make clean`. Right?
Dan.
Hi,
Yes. If a .py file is cleaned but the .pyc exists, the unit test still runs OK using the .pyc file. Those .pyc files will hide some problems in the patch. Cleaning .pyc files can strengthen the build system.
I can have a try on writing a new patch to do this.
on 06/28/2012 18:14, Dan Kenigsberg wrote:
On Thu, Jun 28, 2012 at 05:36:22PM +0800, Zhou Zheng Sheng wrote:
Hi,
I submit a fix at http://gerrit.ovirt.org/5765
Thanks for the quick fix! Taken. I suppose we should clean up those .pyc files on `make clean`. Right?
Dan.
vdsm-devel@lists.fedorahosted.org