On Thu, 30 Sep 2021, Leah Leshchinsky wrote:

Running tuna with the long option --config_file_list without specifying an argument produces an error "option --config_file_list requires argument". This option should not require an argument, and running the short option `tuna -l` does not produce this error.

To allow --config_file_list to be specified without an argument, remove "=" from the "config_file_list" string in the longopts list that is passed to getopt.

Add minor spelling fix in comments.

Signed-off-by: Leah Leshchinsky lleshchi@redhat.com

tuna-cmd.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tuna-cmd.py b/tuna-cmd.py index f9b20f7..8617966 100755 --- a/tuna-cmd.py +++ b/tuna-cmd.py @@ -504,7 +504,7 @@ def main(): "show_irqs", "irqs=", "save=", "sockets=", "threads=", "no_uthreads", "version", "what_is", "spread", "cgroup", "config_file_apply=",

•            "config_file_list=", "run=", "refresh=", "disable_perf"]
  

•            "config_file_list", "run=", "refresh=", "disable_perf"]
     if have_inet_diag:
         short += "n"
         long.append("show_sockets")
  

@@ -570,7 +570,7 @@ def main(): list(map(thread_mapper, a.split(",")))) op_list = list(set(op_list)) thread_list = do_list_op(op, thread_list, op_list)

•            # Check if a process name was especified and no
  

•            # Check if a process name was specified and no
             # threads was found, which would result in an empty
             # thread list, i.e. we would print all the threads
             # in the system when we should print nothing.
  

-- 2.27.0

Thanks

Signed-off-by: John Kacur jkacur@redhat.com