Em Fri, May 11, 2018 at 04:26:16PM +0100, John Kacur escreveu:
On Fri, 11 May 2018, Arnaldo Carvalho de Melo wrote:
> Em Fri, May 11, 2018 at 02:50:21PM +0100, John Kacur escreveu:
> > On Thu, 10 May 2018, Arnaldo Carvalho de Melo wrote:
> >
> > > Em Wed, May 09, 2018 at 11:18:57AM +0100, John Kacur escreveu:
> > > > explicitly use python3 in the shebangs
> > >
> > > I beg your pardon, is this a _requirement_? Will the end result mean
> > > tuna will not anymore run on a python2 only system?
>
> > For now this is in a python3 branch, and I am not asking it be
> > integrated into upstream tuna, I'm just sharing it with everyone.
>
> > However, Fedora is now a python3 by default system, and RedHat 8
> > requires /usr/bin/python3
>
> > We have limited resources so, I envision for the future that we will use
> > python3 by default. People can still use an older version if they require
> > tuna for python2 distributions.
>
> > After a period of making python3 correctly, we could start to take patches
> > that make the same code work correctly for both python3 and python2, but
> > my focus now is python3.
> I'd do it differently, but you're the one doing the work
:-)
> And in the end you haven't answered my question, is this
strictly
> needed? I'm talking about just this single patch :-)
> I'm not saying we should do a lot of work to make it work
with python2,
> I'm just curious if that is the case.
Explicitly refering to python3 in the shebang is a RHEL8 requirement
We don't have to do it in our upstream repo, but doing so at some
point might save us some maintenance headaches.
Ok, that explains, so it is a strict requirement for RHEL8, I'd do it as
a distro specific patch, leaving upstream free of this downstream
specific requirement.
I understand that this could be considered too much and thus the work of
stripping this out could be left for downstreamers wanting to continue
to use python2 or that have already switched completely to python3 and
thus their /usr/bin/python binary _is_ python3.
I.e. I'd keep this patch, just not upstream but instead on the RHEL8
.spec file.
But now at least those trying to review these patches know _why_ this
change was made, i.e. this should've been in the patch commit message.
Thanks,
- Arnaldo