Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: gcore produces incorrect elf_prpsinfo note data
https://bugzilla.redhat.com/show_bug.cgi?id=254229
jan.kratochvil@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #312653|0 |1 is obsolete| |
------- Additional Comments From jan.kratochvil@redhat.com 2008-07-28 17:31 EST ------- Created an attachment (id=312823) --> (https://bugzilla.redhat.com/attachment.cgi?id=312823&action=view) Rawhide (=Fedora 9) patch, v3.
Did some update I would like there. Unfortunately I have some problems with RHTS (partially with YUM) now so it still has not been verifified as regression-free.
Always use xfree(), not free(). GNU indentation: func() -> func (). Always use NULL-protected allocations: xmalloc/xzalloc/... Empty line between declarations and code. /* Two spaces after each sentence dot. Like here. */ `return val;' (with any cleanups) is preceded by an empty line. (Not fixed.) GDB and I believe all the GNU programs limit the line length to 80
characters; some GDB code violates it, though. Write complete sentences in the comments. (Not fixed.) `#if ...\n#define ...'should be indented `#if ...\n# define ...'.
Function parameters should be aligned behind '(' (at `sscanf').
triage@lists.fedoraproject.org