I was hoping you would include `journalctl | grep` commands that would look for the strings Chris mentioned, so that it's easy for people or for scripts to confirm whether the filesystem was or wasn't properly unmounted. It's still helpful to include the examples (they don't necessarily need to be Expected Results, but it's fine there), so that people can compare the full text if they want or have doubts, but those grep commands would make the comparison much simpler.

+1
 

When asking for debug logs, tell people to save the whole journal and not just systemd-fsck output, i.e. `journalctl -b > journal.log`.

I believe the poweroff cycle can be left out, and we can ask just for a single reboot.

+1
I believe that if the system gets properly unmounted for reboot, it does for a poweroff, too.

 

Also, can you please fix the formatting in Expected Results?

I fixed the expected results formatting. I hope you like it.


 

Thanks.
_______________________________________________
test mailing list -- test@lists.fedoraproject.org
To unsubscribe send an email to test-leave@lists.fedoraproject.org
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/test@lists.fedoraproject.org


--

Lukáš Růžička

FEDORA QE, RHCE

Red Hat

Purkyňova 115

612 45 Brno - Královo Pole

lruzicka@redhat.com