Am Mi., 30. Nov. 2022 um 16:50 Uhr schrieb Richard Megginson <
LGTM is being deprecated in favor of CodeQL -
They have submitted several PRs to system roles repos to switch from LGTM
to CodeQL - https://github.com/linux-system-roles/storage/pull/309
Questions for the community:
* Do we need LGTM? Is it useful? Can you give us an example of a problem
found by LGTM that would not have been found otherwise?
when I introduced LGTM to the network role in 2019, it found this issue:
Not sure, if there was any practical impact. The value of services like
these come from the fact that they support reviewers from not having to
deal with issues that can be found automatically so the reviewers can focus
on issues that need a human brain to be found. There does not seem to be
statistics available about how many PRs failed LGTM at some point and then
were fixed by the contributor without the reviewer needing to step in. @Thomas
Haller <thaller(a)redhat.com> fixed some issues in NetworkManager based on
LGTM results that he considered valued and that were not found otherwise
but that is a C project.
* Does anyone have any experience with CodeQL? How is it?
I let it finish the run on the network role and at first glance it seems to
identify valid issues:
I would like to keep it for the network role.
If LGTM isn't useful, I'd like to get rid of it.
> If LGTM is useful, I'll merge the PRs (and remove .lgtm.yml from our repos)
I guess you mean CodeQL here. For the network role, I would prefer to get
the issues fixed before merging the CodeQL PR and the LGTM badge also needs
to be removed from the README.
@Stanislas Faye <sfaye(a)redhat.com> @Wen Liang <wenliang(a)redhat.com> please
consider this for the upcoming sprint.
> Or perhaps there is a better tool we should use instead?
> systemroles mailing list -- systemroles(a)lists.fedorahosted.org
> To unsubscribe send an email to systemroles-leave(a)lists.fedorahosted.org
> Fedora Code of Conduct:
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> Do not reply to spam, report it:
Manager, Software Engineering
NetworkManager, Nmstate, Ansible RHEL Networking System Role
Red Hat GmbH, https://www.redhat.com/de/global/dach
, Registered seat:
Werner von Siemens Ring 12, 85630 Grasbrunn, Germany
Commercial register: Amtsgericht Muenchen/Munich, HRB 153243,
Managing Directors: Ryan Barnhart, Charles Cachera, Michael O'Neill, Amy