Hi Sumit,

great, I'll do that!
Getting rid of the duplication I'll leave for another day though.

Cheers,
Lars

On Fri, Feb 21, 2020 at 9:33 AM Sumit Bose <sbose@redhat.com> wrote:
On Fri, Feb 21, 2020 at 09:08:42AM +0100, Lars Francke wrote:
> Hi,
>
> I was looking at the differences between the defaults in the AD & LDAP
> Provider (when using ldap_schema = ad) and there seems to be a single
> difference.
>
> LDAP: ldap_group_name = name <
> https://pagure.io/SSSD/sssd/blob/master/f/src/providers/ldap/ldap_opts.c#_312
> >
> AD: ldap_group_name = sAMAccountName <
> https://pagure.io/SSSD/sssd/blob/master/f/src/providers/ad/ad_opts.c#_239>
>
> Looking at the AD schema[1] sAMAccountName is part of the group schema but
> I can't find name.
>
> Can anyone remember whether there is a reason for this inconsistency
> between the two?

Hi,

I guess this was just forgotten. The AD version was changed by
https://pagure.io/SSSD/sssd/c/adb148603344a42d6edffdda0786a10af715dacb
and the commit message also explains where 'name' is coming from.

Feel free to open a ticket or send a pull request to fix the ldap
version as well. For the future we should figure out if multiple copies of
this table are really necessary.

bye,
Sumit

>
> Cheers,
> Lars
>
> [1] <https://docs.microsoft.com/en-us/windows/win32/adschema/c-group>
> <https://pagure.io/SSSD/sssd/blob/master/f/src/providers/ad/ad_opts.c#_239>

> _______________________________________________
> sssd-users mailing list -- sssd-users@lists.fedorahosted.org
> To unsubscribe send an email to sssd-users-leave@lists.fedorahosted.org
> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: https://lists.fedorahosted.org/archives/list/sssd-users@lists.fedorahosted.org
_______________________________________________
sssd-users mailing list -- sssd-users@lists.fedorahosted.org
To unsubscribe send an email to sssd-users-leave@lists.fedorahosted.org
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedorahosted.org/archives/list/sssd-users@lists.fedorahosted.org