URL: https://github.com/SSSD/sssd/pull/5361 Author: sumit-bose Title: #5361: negcache: multiple fixes Action: opened
PR body: """ - make sure domain config does not leak into global - make sure short names are added to sub-domains - do not use default_domain_suffix
Resolves: https://github.com/SSSD/sssd/issues/5238 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5361/head:pr5361 git checkout pr5361
URL: https://github.com/SSSD/sssd/pull/5361 Title: #5361: negcache: multiple fixes
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/5361 Title: #5361: negcache: multiple fixes
alexey-tikhonov commented: """ https://github.com/sumit-bose/sssd/blob/f095a01b804d97a46149c9f6593e7e99a63b... -- I think code should `continue` in case of any error, including `EAGAIN` (there are four calls to `sss_parse_name_for_domains()` in this function) """
See the full comment at https://github.com/SSSD/sssd/pull/5361#issuecomment-721770737
URL: https://github.com/SSSD/sssd/pull/5361 Title: #5361: negcache: multiple fixes
alexey-tikhonov commented: """ https://github.com/sumit-bose/sssd/blob/f095a01b804d97a46149c9f6593e7e99a63b... -- I think code should `continue` in case of any error, including `EAGAIN` (there are 3 similar spots in this function) """
See the full comment at https://github.com/SSSD/sssd/pull/5361#issuecomment-721770737
URL: https://github.com/SSSD/sssd/pull/5361 Title: #5361: negcache: multiple fixes
alexey-tikhonov commented: """ Ouch... this stuff appeared to be surprisingly convoluted.
Nonetheless, I think patches are doing right things and should fix both issues seen in https://bugzilla.redhat.com/show_bug.cgi?id=1828483#c4 : short name treated as fqn resulting in unexpanded upn entries and missed name entries (didn't yet test manually though).
With exception of one minor issue and a couple of mistypes, most of my comments are merely questions to make sure I got things right or requests to clarify comments. """
See the full comment at https://github.com/SSSD/sssd/pull/5361#issuecomment-722004646
URL: https://github.com/SSSD/sssd/pull/5361 Title: #5361: negcache: multiple fixes
alexey-tikhonov commented: """
Nonetheless, I think patches are doing right things and should fix both issues seen in https://bugzilla.redhat.com/show_bug.cgi?id=1828483#c4 : short name treated as fqn resulting in unexpanded upn entries and missed name entries (didn't yet test manually though).
Sorry it took that long. I finally verified that those patches resolves both issues seen in https://bugzilla.redhat.com/show_bug.cgi?id=1828483#c4
Covscan is clear.
With exception of one minor issue and a couple of mistypes, most of my comments are merely questions to make sure I got things right or requests to clarify comments.
Marking as "changes requested" to deal with this ^^.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5361#issuecomment-724217089
URL: https://github.com/SSSD/sssd/pull/5361 Title: #5361: negcache: multiple fixes
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/5361 Title: #5361: negcache: multiple fixes
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/5361 Author: sumit-bose Title: #5361: negcache: multiple fixes Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5361/head:pr5361 git checkout pr5361
URL: https://github.com/SSSD/sssd/pull/5361 Title: #5361: negcache: multiple fixes
sumit-bose commented: """
https://github.com/sumit-bose/sssd/blob/f095a01b804d97a46149c9f6593e7e99a63b... -- I think code should `continue` in case of any error, including `EAGAIN` (there are 3 similar spots in this function)
Hi,
this missing `continue` for the users is in fact correct and in the following code the name is treated a generic UPN. I changed the debug message to make this more clear.
For groups there are no UPNs should here we should continue on all errors. I fixed the code accordingly and comments.
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/5361#issuecomment-724641235
URL: https://github.com/SSSD/sssd/pull/5361 Title: #5361: negcache: multiple fixes
sumit-bose commented: """ Hi,
thanks for the rigid review, the latest version should address your comments.
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/5361#issuecomment-724642834
URL: https://github.com/SSSD/sssd/pull/5361 Title: #5361: negcache: multiple fixes
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/5361 Title: #5361: negcache: multiple fixes
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/5361 Title: #5361: negcache: multiple fixes
alexey-tikhonov commented: """ Thank you, ACK. """
See the full comment at https://github.com/SSSD/sssd/pull/5361#issuecomment-724731549
URL: https://github.com/SSSD/sssd/pull/5361 Title: #5361: negcache: multiple fixes
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/5361 Title: #5361: negcache: multiple fixes
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/5361 Title: #5361: negcache: multiple fixes
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/5361 Title: #5361: negcache: multiple fixes
Label: +branch: sssd-1-16
URL: https://github.com/SSSD/sssd/pull/5361 Title: #5361: negcache: multiple fixes
pbrezina commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5361
* `master` * fa4b46e7de7297da3c0e37913eab8cba7f103629 - negcache: do not use default_domain_suffix * 0dc81a52e2836010974e9f71b1f3e47c20fd498d - negcache: make sure short names are added to sub-domains * 385af99ff4d5a75d0c1edc9ad830da3eb7478295 - utils: add SSS_GND_SUBDOMAINS flag for get_next_domain() * 0e1bcf77bd73baa0fea64830eb1f4f65a63c7afe - negcache: make sure domain config does not leak into global * `sssd-1-16` * 56d509ad3001101f04c4af050c3da7472032e4cb - negcache: do not use default_domain_suffix * c3207deee7411456827e69d0b72d7d44e7458853 - negcache: make sure short names are added to sub-domains * ea32d0eb61336858aa23697b4e91d420481fc3e2 - utils: add SSS_GND_SUBDOMAINS flag for get_next_domain() * 96bdcbb4441ddf05c065bbafa88e5691300424d1 - negcache: make sure domain config does not leak into global
"""
See the full comment at https://github.com/SSSD/sssd/pull/5361#issuecomment-725986763
URL: https://github.com/SSSD/sssd/pull/5361 Title: #5361: negcache: multiple fixes
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/5361 Title: #5361: negcache: multiple fixes
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/5361 Title: #5361: negcache: multiple fixes
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/5361 Author: sumit-bose Title: #5361: negcache: multiple fixes Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5361/head:pr5361 git checkout pr5361
sssd-devel@lists.fedorahosted.org