URL: https://github.com/SSSD/sssd/pull/912 Title: #912: Created a new sssd-ldap-attributes.5 man page

centos-ci commented: """ Can one of the admins verify this patch? """

See the full comment at https://github.com/SSSD/sssd/pull/912#issuecomment-545203835

URL: https://github.com/SSSD/sssd/pull/912 Title: #912: Created a new sssd-ldap-attributes.5 man page

Label: +Changes requested

URL: https://github.com/SSSD/sssd/pull/912 Title: #912: Created a new sssd-ldap-attributes.5 man page

alexey-tikhonov commented: """

@thalman I see that you have added a "Changes requested" label, may I ask what's needs to be changed?

I believe this is due to CI fails. `mock-build` step failed for Cent-OS and Fedora*.

That doesn't necessary mean your patch is the reason, but this needs investigation. """

See the full comment at https://github.com/SSSD/sssd/pull/912#issuecomment-546261560

URL: https://github.com/SSSD/sssd/pull/912 Author: alexal Title: #912: Created a new sssd-ldap-attributes.5 man page Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/912/head:pr912 git checkout pr912

URL: https://github.com/SSSD/sssd/pull/912 Title: #912: Created a new sssd-ldap-attributes.5 man page

pbrezina commented: """ Thank you for your contribution Alex. You have resolved the mock-build problem, although I would rather like to see the man page listed explicitly, i.e.:

```diff %{_mandir}/man5/sssd-ldap.5 +%{_mandir}/man5/sssd-ldap-attributes.5* ```

Also, you did not include all attribute mapping options, there is **a lot more** of them in sssd-ldap manpage. Please, go through the page again. But this is a good start.

Perhaps, it will help you to match attributes name with these `enum` values from [sdap.h](https://github.com/SSSD/sssd/blob/master/src/providers/ldap/sdap.h#L243). """

See the full comment at https://github.com/SSSD/sssd/pull/912#issuecomment-547395751

URL: https://github.com/SSSD/sssd/pull/912 Title: #912: Created a new sssd-ldap-attributes.5 man page

alexal commented: """ @pbrezina I appreciate your comments. I've made those changes, please see the updated commit. """

See the full comment at https://github.com/SSSD/sssd/pull/912#issuecomment-547476410

URL: https://github.com/SSSD/sssd/pull/912 Title: #912: Created a new sssd-ldap-attributes.5 man page

alexal commented: """ @pbrezina I've fixed the problem with the whitespace. Just wondering if you had a chance to check the most recent changes to those two man pages? Do you have any further requests or everything looks good? """

See the full comment at https://github.com/SSSD/sssd/pull/912#issuecomment-549159200

URL: https://github.com/SSSD/sssd/pull/912 Title: #912: Created a new sssd-ldap-attributes.5 man page

pbrezina commented: """ I still see `ldap_autofs_map_object_class` in `sssd-ldap` but it is an LDAP attribute. I think it would be beneficial to keep autofs attributes options in both `sssd-ldap` and `sssd-ldap-attributes` pages since these needs to be overwritten quite often.

Please, put them inside a new file e.g. in `src/man/include/autofs_attributes.xml` and include it like this:

```xml <xi:include xmlns:xi="http://www.w3.org/2001/XInclude" href="include/autofs_attributes.xml" /> ```

Also, can you split `sssd-ldap-attributes` to section like `USER ATTRIBUTES`, `GROUP ATTRIBUTTES`, `SUDO ATTRIBUTES`, ... """

See the full comment at https://github.com/SSSD/sssd/pull/912#issuecomment-549308649

URL: https://github.com/SSSD/sssd/pull/912 Title: #912: Created a new sssd-ldap-attributes.5 man page

alexal commented: """ @pbrezina I appreciate your comments. Please see the updated commit with the required changes. Does everything look good? """

See the full comment at https://github.com/SSSD/sssd/pull/912#issuecomment-550406362

URL: https://github.com/SSSD/sssd/pull/912 Author: alexal Title: #912: Created a new sssd-ldap-attributes.5 man page Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/912/head:pr912 git checkout pr912

URL: https://github.com/SSSD/sssd/pull/912 Title: #912: Created a new sssd-ldap-attributes.5 man page

alexal commented: """ @pbrezina I just wondering if you had a chance to review the last commit? Do you have any further requests or everything looks good to you? """

See the full comment at https://github.com/SSSD/sssd/pull/912#issuecomment-552796293

URL: https://github.com/SSSD/sssd/pull/912 Title: #912: Created a new sssd-ldap-attributes.5 man page

Label: +Accepted

URL: https://github.com/SSSD/sssd/pull/912 Title: #912: Created a new sssd-ldap-attributes.5 man page

Label: +Ready to push

URL: https://github.com/SSSD/sssd/pull/912 Title: #912: Created a new sssd-ldap-attributes.5 man page

Label: +Pushed

URL: https://github.com/SSSD/sssd/pull/912 Title: #912: Created a new sssd-ldap-attributes.5 man page

Label: -Ready to push