On 10/15/2009 01:24 PM, Simo Sorce wrote:
On Thu, 2009-10-15 at 12:51 -0400, Stephen Gallagher wrote:
> Most of these warnings are seen only on older platforms like RHEL5.
>
> 0001: Clean up warnings in pysss.c
Shouldn't we just use discard_const_p() in these cases ?
It doesn't look like the underlying code is ever going to change the
format string anyway, so discard_const_p() would be safe and would avoid
a lot of memory allocation.
Yeah, you're right. Revised patch attached.
Related: There are some places in pysss.c (specifically the
initialization of sss_local_methods) where we cannot use
discard_const_p, and the older python headers are expecting a char *.
Any ideas how to solve that? (It's not a blocking issue for this patch,
but it would allow us to come closer to a warning-free build)
> 0002: Remove warnings caused by
> 5e2301b8a75d10e5cbbe11e26e5192b894af6ad7
>
> There were unused functions still being compiled. This will
> suppress them until we turn live configuration updates back on.
ack
> 0003: Remove two unused functions.
>
> These functions were used when reconnecting to the DP after losing
> the connection. Since there is no DP any longer, there's no reason
> to have these functions.
ack
Simo.
--
Stephen Gallagher
RHCE 804006346421761
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/