URL: https://github.com/SSSD/sssd/pull/5945 Author: justin-stephenson Title: #5945: INTG: Restrict smartcard in sc auth tests Action: opened
PR body: """ Smartcard auth related tests can fail when integration tests are run on a machine(F34) with a yubikey inserted. Add a `p11_uri` option to filter only the softhsm2-used integration test cards. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5945/head:pr5945 git checkout pr5945
URL: https://github.com/SSSD/sssd/pull/5945 Author: justin-stephenson Title: #5945: INTG: Restrict smartcard in sc auth tests Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5945/head:pr5945 git checkout pr5945
URL: https://github.com/SSSD/sssd/pull/5945 Title: #5945: INTG: Restrict smartcard in sc auth tests
sumit-bose commented: """ Hi,
thanks for the patch, it should make the Smartcard auth unit tests more resilient. ACK
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/5945#issuecomment-1009927412
URL: https://github.com/SSSD/sssd/pull/5945 Title: #5945: INTG: Restrict smartcard in sc auth tests
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/5945 Title: #5945: INTG: Restrict smartcard in sc auth tests
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/5945 Title: #5945: INTG: Restrict smartcard in sc auth tests
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/5945 Title: #5945: INTG: Restrict smartcard in sc auth tests
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/5945 Title: #5945: INTG: Restrict smartcard in sc auth tests
justin-stephenson commented: """ Please hold off on pushing this, I found that pam-srv-tests unit tests are failing also for the same reason. I'd like to add a commit here to fix this. """
See the full comment at https://github.com/SSSD/sssd/pull/5945#issuecomment-1013270149
URL: https://github.com/SSSD/sssd/pull/5945 Author: justin-stephenson Title: #5945: INTG: Restrict smartcard in sc auth tests Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5945/head:pr5945 git checkout pr5945
URL: https://github.com/SSSD/sssd/pull/5945 Title: #5945: INTG: Restrict smartcard in sc auth tests
justin-stephenson commented: """
Please hold off on pushing this, I found that pam-srv-tests unit tests are failing also for the same reason. I'd like to add a commit here to fix this.
I added changes to the unit tests to fix this, amending the existing commit here. The array size change is needed because after these changes the `--uri` option is added to extra_args, and some tests (test_pam_cert_auth) arg_c now have a count of 18
Please re-review when able to, nothing urgent of course :smile: """
See the full comment at https://github.com/SSSD/sssd/pull/5945#issuecomment-1013475474
URL: https://github.com/SSSD/sssd/pull/5945 Title: #5945: INTG: Restrict smartcard in sc auth tests
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/5945 Title: #5945: INTG: Restrict smartcard in sc auth tests
sumit-bose commented: """ Hi,
thanks, I'm still fine with the patches. I'd just like to ask to split out the change to `pamsrv_p11.c` into an extra patch? The change is not only related to the tests.
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/5945#issuecomment-1014300022
URL: https://github.com/SSSD/sssd/pull/5945 Author: justin-stephenson Title: #5945: INTG: Restrict smartcard in sc auth tests Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5945/head:pr5945 git checkout pr5945
URL: https://github.com/SSSD/sssd/pull/5945 Title: #5945: INTG: Restrict smartcard in sc auth tests
justin-stephenson commented: """
Hi,
thanks, I'm still fine with the patches. I'd just like to ask to split out the change to `pamsrv_p11.c` into an extra patch? The change is not only related to the tests.
bye, Sumit
Fixed, thanks. """
See the full comment at https://github.com/SSSD/sssd/pull/5945#issuecomment-1014532616
URL: https://github.com/SSSD/sssd/pull/5945 Title: #5945: INTG: Restrict smartcard in sc auth tests
sumit-bose commented: """ Hi,
thank you. ACK.
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/5945#issuecomment-1015169276
URL: https://github.com/SSSD/sssd/pull/5945 Title: #5945: INTG: Restrict smartcard in sc auth tests
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/5945 Title: #5945: INTG: Restrict smartcard in sc auth tests
Label: -Waiting for review
sssd-devel@lists.fedorahosted.org