This is the set of patches that start to build up the new INI config
Since some functionality required additions to the collection the
collection was updated.
All the the patches have patch comments that explain what the patch does
if it is not clear from the name.
I tried to keep the patches small for easier review. Only one is
actually big but has an extensive comment explaining the logic.
The patches should be applied in the provided order on top of the 6
patches that are currently pending.
0001--COLLECTION-Allow-destroying-collection-with-a-call.patch - adds a
cleanup with callback
0002--BASICOBJ-Added-a-convenience-function.patch - I was struggling
with type casting. It turned that it is simpler just to add a function
that adds a const char* instead of type casting to void *.
0003--INI-More-config-files-for-testing.patch - Needed a variety of the
config files to test so added couple
0004--INI-Extend-the-comment-interface.patch -Added a function to use
already known length of the string instead of counting it again.
0005--INI-Add-error-codes-for-the-new-parser.patch - New parser will
require couple new error codes, so I added them
0006--INI-Fixes-to-the-value-object.patch - Value object has some issues
so was corrected and enhanced.
0007--INI-The-beginning-of-the-new-INI-interface.patch - Started the new
high level config interface obscuring the collection.
0008--INI-New-INI-parser.patch - (BIG!) The INI new parser.
Corrected the versions of the libraries and projects
Also noticed that the spec file should be updated to include the basic
object. I think we need a separate ticket for that. Agree?
I can try to do it but probably a bit later.
I tested new code with unit tests and ran it via valgrind.
The patches are starting to pile up and rot. I already had some hard
time merging them with the spec file.
I understand that we have other priorities but we need to come up with
some way with dealing with these patches too.
Engineering Manager IPA project,
Red Hat Inc.
Looking to carve out IT costs?