-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Introduces a new option --debug-to-files which makes SSSD output its debug information to a file instead of stderr, which is still the default.
Also introduces a new confdb option debug_to_files which does the same, but can be specified per-service in the config file.
The logfiles are stored in /var/log/sssd by default.
I also removed two lines in Makefile.am that still referenced shadow-utils, don't think it warrants a separate patch.
Jakub
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 09/23/2009 07:16 PM, Jakub Hrozek wrote:
Introduces a new option --debug-to-files which makes SSSD output its debug information to a file instead of stderr, which is still the default.
Also introduces a new confdb option debug_to_files which does the same, but can be specified per-service in the config file.
The logfiles are stored in /var/log/sssd by default.
I also removed two lines in Makefile.am that still referenced shadow-utils, don't think it warrants a separate patch.
Jakub
I accidentally sent a patch from branch with the confdb 2.0 changes, so it did not apply cleanly. Resending.
On Thu, Sep 24, 2009 at 11:56:00AM +0200, Jakub Hrozek wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 09/23/2009 07:16 PM, Jakub Hrozek wrote:
Introduces a new option --debug-to-files which makes SSSD output its debug information to a file instead of stderr, which is still the default.
Also introduces a new confdb option debug_to_files which does the same, but can be specified per-service in the config file.
The logfiles are stored in /var/log/sssd by default.
I also removed two lines in Makefile.am that still referenced shadow-utils, don't think it warrants a separate patch.
Jakub
I accidentally sent a patch from branch with the confdb 2.0 changes, so it did not apply cleanly. Resending.
Hi,
is it possible to open the debug file earlier in server_setup to catch all messages from server_setup?
bye, Sumit
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 09/24/2009 02:07 PM, Sumit Bose wrote:
Hi,
is it possible to open the debug file earlier in server_setup to catch all messages from server_setup?
bye, Sumit
As discussed on IRC, we cannot open the debug file until we initialize the confdb and read the debug-to-files parameter. So I at least moved the DEBUG(3, "CONFDB: %s", ...) debug message below the logging setup.
Also added a note in the manpage to describe the new option.
Jakub
On Fri, 2009-09-25 at 12:35 +0200, Jakub Hrozek wrote:
/* set up things like debug , signals, daemonization, etc... */
- debug_log_file = talloc_strdup(NULL, "sssd_pam");
- if (debug_log_file == NULL) return 2;
debug_log_file is a process constant, it's useless to allocate memory to copy a constant string you'll never release nor change.
Please replace with a simple: debug_log_file = "sssd_pam";
Simo.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 09/25/2009 06:35 AM, Jakub Hrozek wrote:
On 09/24/2009 02:07 PM, Sumit Bose wrote:
Hi,
is it possible to open the debug file earlier in server_setup to catch all messages from server_setup?
bye, Sumit
As discussed on IRC, we cannot open the debug file until we initialize the confdb and read the debug-to-files parameter. So I at least moved the DEBUG(3, "CONFDB: %s", ...) debug message below the logging setup.
Also added a note in the manpage to describe the new option.
Jakub
Why did you use asprintf() instead of talloc_asprintf() in open_debug_log()?
Please update sysv/sssd to use debug-to-files by default (at level 0), so that critical failures will appear in the logs.
- ------------------------------------------------------------------------
_______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
- -- Stephen Gallagher RHCE 804006346421761
Looking to carve out IT costs? www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 09/25/2009 12:47 PM, Stephen Gallagher wrote:
Why did you use asprintf() instead of talloc_asprintf() in open_debug_log()?
discussed on IRC
Please update sysv/sssd to use debug-to-files by default (at level 0), so that critical failures will appear in the logs.
Done, also with Simo's comments about dup-ing static strings.
Jakub
On Fri, 2009-09-25 at 13:13 +0200, Jakub Hrozek wrote:
On 09/25/2009 12:47 PM, Stephen Gallagher wrote:
Why did you use asprintf() instead of talloc_asprintf() in
open_debug_log()?
discussed on IRC
Please update sysv/sssd to use debug-to-files by default (at level
0),
so that critical failures will appear in the logs.
Done, also with Simo's comments about dup-ing static strings.
ack by me.
Simo.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 09/25/2009 01:50 PM, Simo Sorce wrote:
Please update sysv/sssd to use debug-to-files by default (at level 0),
so that critical failures will appear in the logs.
Done, also with Simo's comments about dup-ing static strings.
ack by me.
Simo.
attached is a patch rebased on top of the latest confdb patches.
The only change is that sssd.spec.in is patched to own the /var/log/sssd directory.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 09/25/2009 09:26 AM, Jakub Hrozek wrote:
On 09/25/2009 01:50 PM, Simo Sorce wrote:
Please update sysv/sssd to use debug-to-files by default (at level 0),
so that critical failures will appear in the logs.
Done, also with Simo's comments about dup-ing static strings.
ack by me.
Simo.
attached is a patch rebased on top of the latest confdb patches.
The only change is that sssd.spec.in is patched to own the /var/log/sssd directory.
Nack /var/log/audit != /var/log/sssd
- ------------------------------------------------------------------------
_______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
- -- Stephen Gallagher RHCE 804006346421761
Looking to carve out IT costs? www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 09/25/2009 03:28 PM, Stephen Gallagher wrote:
Nack /var/log/audit != /var/log/sssd
Stupid copy'n'paste..sorry..
new patch attached
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 09/25/2009 09:48 AM, Jakub Hrozek wrote:
On 09/25/2009 03:28 PM, Stephen Gallagher wrote:
Nack /var/log/audit != /var/log/sssd
Stupid copy'n'paste..sorry..
new patch attached
Ack and pushed
- ------------------------------------------------------------------------
_______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
- -- Stephen Gallagher RHCE 804006346421761
Looking to carve out IT costs? www.redhat.com/carveoutcosts/
sssd-devel@lists.fedorahosted.org