On 03/10/2016 01:05 PM, Lukas Slebodnik wrote:
On (10/03/16 12:58), Pavel Březina wrote:
> On 03/09/2016 05:39 PM, Lukas Slebodnik wrote:
>> I read log files from latest 1.13 today and it was a small challenge
>> due to missing line feed after some ldb messages.
> Can we check if new line is present instead of always appending it?
We do not always append it. We append it only in libldb.
Because libldb is inconsistent. I sent patch to samba upstream
That's why I ask for it.
but we cannot reply on specific version of libldb.
In future, we can conditionally remove this flag if we detect there is
recent enough libldb.
We could append it but it would be additional slowdown in debug messages
even in other parts of code which already have line feed in message
(sssd debug messages, libhbac ...)
It doesn't need to be on sssd debug, but only in ldb_debug_messages. I
don't think that if (fmt[strlen-1] '= '\n') is such a slow down, but I
Ack to the patches then.
I recently removed unnecessary slowdown with removing "asprintf"
and I would like to avoid adding additional complex logic to
sssd-devel mailing list