URL: https://github.com/SSSD/sssd/pull/5930 Author: shridhargadekar Title: #5930: Tests: Health and Support Analyzer - Add request log parsing utility Action: opened
PR body: """ Tests for Health and Support Analyzer - Add request log parsing utility Verifies: #5712 Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1294670 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5930/head:pr5930 git checkout pr5930
URL: https://github.com/SSSD/sssd/pull/5930 Title: #5930: Tests: Health and Support Analyzer - Add request log parsing utility
Label: +Tests
URL: https://github.com/SSSD/sssd/pull/5930 Title: #5930: Tests: Health and Support Analyzer - Add request log parsing utility
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/5930 Author: shridhargadekar Title: #5930: Tests: Health and Support Analyzer - Add request log parsing utility Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5930/head:pr5930 git checkout pr5930
URL: https://github.com/SSSD/sssd/pull/5930 Title: #5930: Tests: Health and Support Analyzer - Add request log parsing utility
aborah-sudo commented: """ LGTM """
See the full comment at https://github.com/SSSD/sssd/pull/5930#issuecomment-998750012
URL: https://github.com/SSSD/sssd/pull/5930 Title: #5930: Tests: Health and Support Analyzer - Add request log parsing utility
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/5930 Title: #5930: Tests: Health and Support Analyzer - Add request log parsing utility
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/5930 Title: #5930: Tests: Health and Support Analyzer - Add request log parsing utility
justin-stephenson commented: """ Hi Shridhar,
https://github.com/SSSD/sssd/pull/5863 changed how the chain ID is logged in responders, and also changed the analyzer log parsing to cope with this. I haven't checked but it may require these analyzer tests to be updated.
If you have any questions feel free to ping me. """
See the full comment at https://github.com/SSSD/sssd/pull/5930#issuecomment-1000328536
URL: https://github.com/SSSD/sssd/pull/5930 Title: #5930: Tests: Health and Support Analyzer - Add request log parsing utility
Label: +Blocked
URL: https://github.com/SSSD/sssd/pull/5930 Title: #5930: Tests: Health and Support Analyzer - Add request log parsing utility
alexey-tikhonov commented: """
#5863 changed how the chain ID is logged in responders, and also changed the analyzer log parsing to cope with this. I haven't checked but it may require these analyzer tests to be updated.
Marking as "blocked" until this comment replied. """
See the full comment at https://github.com/SSSD/sssd/pull/5930#issuecomment-1001567603
URL: https://github.com/SSSD/sssd/pull/5930 Title: #5930: Tests: Health and Support Analyzer - Add request log parsing utility
shridhargadekar commented: """
Hi Shridhar,
#5863 changed how the chain ID is logged in responders, and also changed the analyzer log parsing to cope with this. I haven't checked but it may require these analyzer tests to be updated.
If you have any questions feel free to ping me.
I checked the PR against latest package version, and this PR executes the tests correctly. From latest changes in sssd version, above tests do not need any changes. However More tests could be added. """
See the full comment at https://github.com/SSSD/sssd/pull/5930#issuecomment-1006003668
URL: https://github.com/SSSD/sssd/pull/5930 Title: #5930: Tests: Health and Support Analyzer - Add request log parsing utility
shridhargadekar commented: """
Hi Shridhar,
#5863 changed how the chain ID is logged in responders, and also changed the analyzer log parsing to cope with this. I haven't checked but it may require these analyzer tests to be updated.
If you have any questions feel free to ping me.
@justin-stephenson , I checked the PR against latest package version, and this PR executes the tests correctly. From latest changes in sssd version, above tests do not need any changes. However More tests could be added. """
See the full comment at https://github.com/SSSD/sssd/pull/5930#issuecomment-1006003668
URL: https://github.com/SSSD/sssd/pull/5930 Title: #5930: Tests: Health and Support Analyzer - Add request log parsing utility
Label: -Blocked
URL: https://github.com/SSSD/sssd/pull/5930 Title: #5930: Tests: Health and Support Analyzer - Add request log parsing utility
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/5930 Title: #5930: Tests: Health and Support Analyzer - Add request log parsing utility
alexey-tikhonov commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5930
* `master` * 58b3233f06c796c0928a80da63fe01a1c1fa05a4 - Tests: Health and Support Analyzer - Add request log parsing utility
"""
See the full comment at https://github.com/SSSD/sssd/pull/5930#issuecomment-1006508020
URL: https://github.com/SSSD/sssd/pull/5930 Title: #5930: Tests: Health and Support Analyzer - Add request log parsing utility
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/5930 Title: #5930: Tests: Health and Support Analyzer - Add request log parsing utility
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/5930 Title: #5930: Tests: Health and Support Analyzer - Add request log parsing utility
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/5930 Author: shridhargadekar Title: #5930: Tests: Health and Support Analyzer - Add request log parsing utility Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5930/head:pr5930 git checkout pr5930
sssd-devel@lists.fedorahosted.org