Date: Tue, 22 May 2012 11:22:41 +0200
From: jhrozek(a)redhat.com
To: sssd-devel(a)lists.fedorahosted.org
Subject: Re: [SSSD] [PATCH] 1213-Warn to syslog when dereference requests fail
On Mon, May 21, 2012 at 10:02:19PM -0500, Ariel Barria wrote:
> thanks for you time and explanation.
>
> > Date: Mon, 21 May 2012 12:43:37 +0200
> > From: jhrozek(a)redhat.com
> > To: sssd-devel(a)lists.fedorahosted.org
> > Subject: Re: [SSSD] [PATCH] 1213-Warn to syslog when dereference
> requests fail
> >
> > On Fri, May 18, 2012 at 12:18:31AM -0500, Ariel Barria wrote:
> > >
https://fedorahosted.org/sssd/ticket/1213
> >
> > Hi,
> >
> > I think only the changes in sdap_deref_search_done are needed.
> >
> > I was trying to find a tevent introduction but the best I could find
> was:
> >
http://tevent.samba.org/modules.html and in particular the example at
> >
>
http://tevent.samba.org/group__tevent__request.html#ga680dd2f03889aa70471...
> >
> > In short - the _send function only creates an asynchronous request. The
> > _done function is called when the request actually completes. In the
> > sdap_deref_search_done, you can see the return code being retrieved from
> > a sub request. Finally the _recv function is available to the caller of
> > the original _send function to retrieve the return code.
> >
> > Finally, you don't need to enclose the message of sss_log (the second
> > parameter) in brackets. The message in the DEBUG macro is enclosed
> > because the macro parameter is expanded verbatim as a parameter list of
> > a printf-style debug function, see util.h:
> > 141 } \
> > 142 debug_fn body; \
> > 143 } \
> > 144 } while(0)
> > 145
Looks good to me now, ack
Just please add a space after the comma in the sss_log call before
pushing.
_______________________________________________
sssd-devel mailing list
sssd-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel