URL:
https://github.com/SSSD/sssd/pull/424
Title: #424: TOOLS: Add a new sssctl command access-report
jhrozek commented:
"""
Self-nack, coverity found some issues:
```
Error: UNINIT (CWE-457):
sssd-1.16.1/src/providers/ipa/ipa_access.c:714: var_decl: Declaring variable
"ret" without initializer.
sssd-1.16.1/src/providers/ipa/ipa_access.c:727: uninit_use_in_call: Using uninitialized
value "ret" when calling "_tevent_req_error".
# 725| subreq = ipa_fetch_hbac_send(state, params->ev, params->be_ctx,
access_ctx);
# 726| if (subreq == NULL) {
# 727|-> tevent_req_error(req, ret);
# 728| tevent_req_post(req, params->ev);
# 729| return req;
Error: UNINIT (CWE-457):
sssd-1.16.1/src/tools/sssctl/sssctl_access_report.c:277: var_decl: Declaring variable
"ret" without initializer.
sssd-1.16.1/src/tools/sssctl/sssctl_access_report.c:315: uninit_use: Using uninitialized
value "ret".
# 313| done:
# 314| talloc_free(tmp_ctx);
# 315|-> return ret;
# 316| }
# 317|
Error: COMPILER_WARNING:
sssd-1.16.1/src/tools/sssctl/sssctl_access_report.c: scope_hint: In function
'sssctl_ipa_access_report'
sssd-1.16.1/src/tools/sssctl/sssctl_access_report.c:340:8: warning: 'ret' may be
used uninitialized in this function [-Wmaybe-uninitialized]
# if (ret != EOK) {
# ^
# 338| /* Run the pam account phase to make sure the rules are fetched by SSSD */
# 339| ret = refresh_hbac_rules(tool_ctx, domain);
# 340|-> if (ret != EOK) {
# 341| ERROR("Unable to refresh HBAC rules, using cached
content\n");
# 342| /* Non-fatal */
```
"""
See the full comment at
https://github.com/SSSD/sssd/pull/424#issuecomment-345361656