Title: #418: CACHE_REQ: Copy the cr_domain list for each request
We've had another round of discussions on IRC and I've decided to update the patch
as it is, just adding the link to the pagure issue.
The reason behind this is that adding the reference counter to this code does not seen to
bring a lot of benefits, but does bring some more complexity. I've a
where refcount is half-baked and half-broken and in case someone wants to take a look and
chime in to help, I'd appreciate (maybe it'll make me change my mind).
Apart from this copying approach, the ref_count approach, there was a third option
discussed that would be changing the cr_domains list instead of throwing it away and
rebuilding it as we currently do. This option also does not bring a lot of benefits as,
for safety reasons, we'd have to ensure that this list doesn't change during the
cache req request (then we're back to the first 2 options).
So, my proposal here is to have it as it is and I'd like to hear the opinion of the
other developers on this one (specially from @pbrezina who knows cache_req quite well;
@jhrozek who remebers having some issues with our ref_count module; and @sumit-bose who
came up with the suggestions in the first place).
I'm removing the "Changes Requested" label as from now on this PR is no
longer blocked on me.
See the full comment at https://github.com/SSSD/sssd/pull/418#issuecomment-338242063