URL: https://github.com/SSSD/sssd/pull/709 Author: tdukaric Title: #709: Regex fails if there's a whitespace before option name Action: opened
PR body: """ self.OPTCRE.match(line) fails if there's a whitespace before option name, which is valid for SSSD. This change will ignore any whitespace before the option name. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/709/head:pr709 git checkout pr709
URL: https://github.com/SSSD/sssd/pull/709 Title: #709: Regex fails if there's a whitespace before option name
centos-ci commented: """ Can one of the admins verify this patch? """
See the full comment at https://github.com/SSSD/sssd/pull/709#issuecomment-445134373
URL: https://github.com/SSSD/sssd/pull/709 Title: #709: Regex fails if there's a whitespace before option name
jhrozek commented: """ ok to test """
See the full comment at https://github.com/SSSD/sssd/pull/709#issuecomment-445157651
URL: https://github.com/SSSD/sssd/pull/709 Title: #709: Regex fails if there's a whitespace before option name
jhrozek commented: """ @mzidek-rh do you have some opinion on the patch? """
See the full comment at https://github.com/SSSD/sssd/pull/709#issuecomment-445157860
URL: https://github.com/SSSD/sssd/pull/709 Title: #709: Regex fails if there's a whitespace before option name
mzidek-rh commented: """ I will check in ding-libs if we have support for whitespaces before option name, but I suspect that it could collide with the multiline values feature in ding-libs. So it may work by accident and is not really supported (but again I need to check in ding-libs code), """
See the full comment at https://github.com/SSSD/sssd/pull/709#issuecomment-448603242
URL: https://github.com/SSSD/sssd/pull/709 Title: #709: Regex fails if there's a whitespace before option name
thalman commented: """ Here is my investigation on this:
In sssd we use INI_PARSE_NOWRAP i. e. no multiline items. On the other side we do not use INI_PARSE_NOSPACE so leading space/tab in sssd.conf are allowed.
Therefore I think it is fine to merge it. """
See the full comment at https://github.com/SSSD/sssd/pull/709#issuecomment-499821551
URL: https://github.com/SSSD/sssd/pull/709 Title: #709: Regex fails if there's a whitespace before option name
mzidek-rh commented: """ @thalman Thanks, you are correct, with the multiline feature suppressed the patch is safe. """
See the full comment at https://github.com/SSSD/sssd/pull/709#issuecomment-499838415
URL: https://github.com/SSSD/sssd/pull/709 Title: #709: Regex fails if there's a whitespace before option name
jhrozek commented: """ Can either of you set +Accepted so I can push the patch? """
See the full comment at https://github.com/SSSD/sssd/pull/709#issuecomment-499847578
URL: https://github.com/SSSD/sssd/pull/709 Title: #709: Regex fails if there's a whitespace before option name
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/709 Title: #709: Regex fails if there's a whitespace before option name
jhrozek commented: """ * master: aa73e296ba392f4222134ce68cd4ec5fe8adb7f5 """
See the full comment at https://github.com/SSSD/sssd/pull/709#issuecomment-500769293
URL: https://github.com/SSSD/sssd/pull/709 Author: tdukaric Title: #709: Regex fails if there's a whitespace before option name Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/709/head:pr709 git checkout pr709
URL: https://github.com/SSSD/sssd/pull/709 Title: #709: Regex fails if there's a whitespace before option name
Label: +Pushed
sssd-devel@lists.fedorahosted.org
-
centos-ci -
jhrozek
-
mzidek-rh
-
tdukaric
-
thalman