-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 11/19/2009 02:45 PM, Jakub Hrozek wrote:
On 11/17/2009 04:16 PM, Jakub Hrozek wrote:
> On 11/17/2009 12:16 PM, Jakub Hrozek wrote:
>> On 11/17/2009 01:06 AM, Jakub Hrozek wrote:
>>> [PATCH 1/2] Add Simo's ipachangeconf
>>> This patch adds the ipachangeconf class from FreeIPA and packages it in
>>> makefile and with python setuptools
>>> [PATCH 2/2] Change the upgrade script to use ipachangeconf
>>> With this patch, the upgrade script we use for changing the config files
>>> is able to keep ordering and comments.
>>> Fixes: #249
>> Self-NACK to patch 2 & new patches attached.
> As discussed on IRC, I'm resending the same two patches, just formatted
> with git format-patch -M to detect renamed upgrade script
I have merged the patches for the upgrade script with the SSSDConfig
patches into this thread. I think it makes sense to review them together:
[PATCH 1/6] Add Simo's ipachangeconf
This patch adds the ipahangeconf class from FreeIPA and packages it in
makefile and with python setuptools
Ack
[PATCH 2/6] SSSDChangeConf - a wrapper around ipachangeconf
Provides a convenient wrapper around ipachangeconf that is closer
API-wise to ConfigParser
Ack
[PATCH 3/6] Change the upgrade script to use ipachangeconf
With this patch, the upgrade script we use for changing the config files
is able to keep ordering and comments.
Fixes: #249
Ack
[PATCH 4/6] Convert SSSDConfig API to ipachangeconf
With this patch, SSSDConfigAPI is able to keep comments and ordering of
sections.
Fixes: #226
Ack
[PATCH 5/6] SSSDConfigAPI fixes
* splitlist is a function
* shared SSSDConfigObject to reduce code duplication
* added missing exception class
* fixed some typos
* remove extra 'pass' in unittests
* use assertRaises in unittests
Ack
[PATCH 6/6] upgrade_config fixes for SSSD 0.6 and later
Incorporates changes we made to v2 after 0.6, or that were missed by the
original upgrade script:
* removes magic_private_groups option
* removes libPath option
* changes provider=files to provider=proxy proxy_lib_name=files
Nack.
Still missing the conversion from store-legacy-passwords to
store_legacy_passwords. Otherwise fine.
_______________________________________________
sssd-devel mailing list
sssd-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAksGkWkACgkQeiVVYja6o6NXRwCcC7fYVpf1t/+Ee/AnEn12LVbA
AeIAoK1E9K2KEhr/GtWI/nL5xjvABcIi
=Z32n
-----END PGP SIGNATURE-----