-----BEGIN PGP SIGNED MESSAGE-----
On 02/12/2010 08:04 AM, Sumit Bose wrote:
On Tue, Feb 09, 2010 at 03:46:10PM -0500, Stephen Gallagher wrote:
On 02/08/2010 03:34 AM, Sumit Bose wrote:
>>> On Fri, Feb 05, 2010 at 12:25:05PM -0500, Stephen Gallagher wrote:
>>> These three patches are the first steps towards an sssd-devel package.
>>> Patch 0001: Build the confdb as a shared library. This is so that
>>> third-party backend implementers can access our configuration if they
>>> Patch 0002: Add comprehensive doxygen docs for the confdb
>>> Patch 0003: Add a -devel subpackage to the sssd.spec for the confdb and
>>> its docs.
>>>> I think patch 2 and 3 are still useful and should be include although I
>>>> would NACK them because of a missing 'BuildRequires: doxygen'.
I think only patch 2 makes sense at all, since if the confdb is not
going to be a public interface, we probably don't need to package its
I've attached an updated version of patch 0002 that will not build the
documentation automatically; only when 'make docs' is run.
> I have two comments:
> +docs: all
> + $(MAKE) -C server $@
> why do I have 'make all' before I can create the docs?
> It would be nice to get a message about missing doxygen instead of
> 'true doxy.config' if doxygen is not installed.
Ah, these are leftovers from when I was building the docs as part of the
installable data (for the RPM).
We don't need the dependency on 'all', and I can change the configure
test for doxygen. Replacing $(DOXYGEN) with 'true' was there to ensure
that 'make install' didn't fail trying to build the docs.
I will prepare a new patch.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
-----END PGP SIGNATURE-----