Hi,
this path reintroduces the old way of handling the file description of a LDAP connection if the connection callback is not available.
Using the old way we cannot handle LDAP referrals and I think we should generate a DEBUG message if ldap_referrals is set to 'true' and add a hint to the man page. Do you agree? I didn't put these changes in the patch to make the review easier because if can be compared line by line with commit 7c8f422495347e6ff829246ebf5d7faad9f6d160 'Use ldap connection callbacks to get file descriptors'.
bye, Sumit
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 02/04/2010 08:15 AM, Sumit Bose wrote:
Hi,
this path reintroduces the old way of handling the file description of a LDAP connection if the connection callback is not available.
Using the old way we cannot handle LDAP referrals and I think we should generate a DEBUG message if ldap_referrals is set to 'true' and add a hint to the man page. Do you agree? I didn't put these changes in the patch to make the review easier because if can be compared line by line with commit 7c8f422495347e6ff829246ebf5d7faad9f6d160 'Use ldap connection callbacks to get file descriptors'.
bye, Sumit
The patch looks fine. I'd like to see the man page specify that ldap_referrals do not work for openldap libraries older than 2.4.12.
The debug message should reflect the same.
Please resubmit with these two changes.
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
On Thu, Feb 04, 2010 at 09:02:51AM -0500, Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 02/04/2010 08:15 AM, Sumit Bose wrote:
Hi,
this path reintroduces the old way of handling the file description of a LDAP connection if the connection callback is not available.
Using the old way we cannot handle LDAP referrals and I think we should generate a DEBUG message if ldap_referrals is set to 'true' and add a hint to the man page. Do you agree? I didn't put these changes in the patch to make the review easier because if can be compared line by line with commit 7c8f422495347e6ff829246ebf5d7faad9f6d160 'Use ldap connection callbacks to get file descriptors'.
bye, Sumit
The patch looks fine. I'd like to see the man page specify that ldap_referrals do not work for openldap libraries older than 2.4.12.
The debug message should reflect the same.
Please resubmit with these two changes.
man page change and debug message are in the second patch.
bye, Sumit
Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAktq04sACgkQeiVVYja6o6OOuwCdGDpYQNYgRCrKlD8fq6WPFiGi FEYAn1HWCbdPyiWJ+6Dm6qGbWBvZa5Gf =f6sA -----END PGP SIGNATURE----- _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
On Thu, Feb 04, 2010 at 08:13:15PM +0100, Sumit Bose wrote:
On Thu, Feb 04, 2010 at 09:02:51AM -0500, Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 02/04/2010 08:15 AM, Sumit Bose wrote:
Hi,
this path reintroduces the old way of handling the file description of a LDAP connection if the connection callback is not available.
Using the old way we cannot handle LDAP referrals and I think we should generate a DEBUG message if ldap_referrals is set to 'true' and add a hint to the man page. Do you agree? I didn't put these changes in the patch to make the review easier because if can be compared line by line with commit 7c8f422495347e6ff829246ebf5d7faad9f6d160 'Use ldap connection callbacks to get file descriptors'.
bye, Sumit
The patch looks fine. I'd like to see the man page specify that ldap_referrals do not work for openldap libraries older than 2.4.12.
The debug message should reflect the same.
Please resubmit with these two changes.
man page change and debug message are in the second patch.
sorry, this new version fixes a compiler warning.
bye, Sumit
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 02/05/2010 07:04 AM, Sumit Bose wrote:
man page change and debug message are in the second patch.
sorry, this new version fixes a compiler warning.
Ack to both.
Please open a ticket explaining this issue and mark it as "Affects tests".
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 02/05/2010 07:22 AM, Stephen Gallagher wrote:
On 02/05/2010 07:04 AM, Sumit Bose wrote:
man page change and debug message are in the second patch.
sorry, this new version fixes a compiler warning.
Ack to both.
Please open a ticket explaining this issue and mark it as "Affects tests".
Pushed to master.
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
sssd-devel@lists.fedorahosted.org
-
Stephen Gallagher -
Sumit Bose