URL:
https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider
lslebodn commented:
"""
On (28/03/17 02:48), Pavel Březina wrote:
I fixed simo's comments.
The compilation issue on RHEL7 is fixed simple by removing the argument -- give it's
only a test tool I don't think it is worth spending time implementing this myself.
```c
--- a/src/tests/tcurl_test_tool.c
+++ b/src/tests/tcurl_test_tool.c
@@ -317,7 +317,9 @@ int main(int argc, const char *argv[])
{ "put", 'p', POPT_ARG_NONE, NULL, 'p', "Perform a
HTTP PUT", NULL },
{ "post", 'o', POPT_ARG_NONE, NULL, 'o', "Perform
a HTTP POST", NULL },
{ "del", 'd', POPT_ARG_NONE, NULL, 'd', "Perform a
HTTP DELETE", NULL },
+#ifdef POPT_ARG_ARGV
{ "header", 'h', POPT_ARG_ARGV, &opts.headers,
'\0', "Add HTTP header", NULL },
+#endif
{ "raw", 'r', POPT_ARG_NONE, &opts.raw, '\0',
"Print raw protocol output", NULL },
{ "verbose", 'v', POPT_ARG_NONE, &opts.verbose,
'\0', "Print response code and body", NULL },
/* TLS */
```
I renamed `socket` to `socket_path` so I don't shadow global. And we do not support
secrets nor kcm in rhel6 so it should be configured `--without-secrets --without-kcm`.
The socket was just a warning. But there is an error
'CURLOPT_UNIX_SOCKET_PATH'
because libcurl in el6 does not support unix sockets.
So this binary `tcurl-test-tool` should not be built there.
In `Makefile. am we have
```
if BUILD_WITH_LIBCURL
noinst_PROGRAMS += tcurl-test-tool
endif
```
I assume it was related to the latest patch `build: make curl required by
secrets`. I will need to check with latest version.
BTW the change in configure was done much later then in code.
It shoudl be either in the same patch when curl is required for sssd-secrets
or before.
LS
"""
See the full comment at
https://github.com/SSSD/sssd/pull/198#issuecomment-289766710