URL:
https://github.com/SSSD/sssd/pull/62
Title: #62: PAM: add pam_response_filter option
jhrozek commented:
"""
Thank you for the patch, I started the review and so far I would like to ask for
compilation warnings to be fixed:
```
/home/remote/jhrozek/devel/sssd/src/tests/cmocka/test_pam_srv.c: In function
‘test_filter_response’:
/home/remote/jhrozek/devel/sssd/src/tests/cmocka/test_pam_srv.c:1783:17: warning:
assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
pd->service = "MyService";
^
/home/remote/jhrozek/devel/sssd/src/tests/cmocka/test_pam_srv.c:1793:5: warning: ‘memset’
used with constant zero length parameter; this could be due to transposed parameters
[-Wmemset-transposed-args]
memset(offline_auth_data, sizeof(offline_auth_data), 0);
^~~~~~
CC src/responder/pam/pam_srv_tests-pamsrv_dp.o
In file included from /home/remote/jhrozek/devel/sssd/src/util/util.h:54:0,
from /home/remote/jhrozek/devel/sssd/src/responder/pam/pamsrv_cmd.c:24:
/home/remote/jhrozek/devel/sssd/src/responder/pam/pamsrv_cmd.c: In function
‘filter_responses_env’:
/home/remote/jhrozek/devel/sssd/src/responder/pam/pamsrv_cmd.c:522:15: warning: field
precision specifier ‘.*’ expects argument of type ‘int’, but argument 6 has type ‘size_t
{aka long unsigned int}’ [-Wformat=]
"Found PAM ENV filter for variable [%.*s] and service [%s].\n",
^
/home/remote/jhrozek/devel/sssd/src/util/debug.h:108:22: note: in definition of macro
‘DEBUG’
format, ##__VA_ARGS__); \
^~~~~~
```
"""
See the full comment at
https://github.com/SSSD/sssd/pull/62#issuecomment-257556911