On 03/25/2010 03:53 PM, Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 03/25/2010 03:51 PM, John Dennis wrote:
> On 03/25/2010 03:41 PM, Stephen Gallagher wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> These unit tests are paying off already. This segfault would have caused
>> problems in libpath_utils.
>>
>> This patch also addresses a failure in path_split() to initialize a
>> return value.
>
> Very Good.
>
> ACK
>
> You found that very quickly, just looking at the code or did a tool pick
> it up?
>
Valgrind alerted me to an invalid write, and I identified the cause from
there.
My valgrind on F-12 (32-bit i686) didn't report any problems, how weird.
--
John Dennis <jdennis(a)redhat.com>
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/