-----BEGIN PGP SIGNED MESSAGE-----
On 09/18/2009 05:32 PM, Stephen Gallagher wrote:
Patch looks good except for one thing:
Why did you omit the confdb and sysdb from this patch? Notably, we would
definitely want any configuration failures written to the syslog.
I should have probably mentioned this in the patch..so, confdb and sysdb
are used also outside the server, in tools. I don't think the tools
should write anything to syslog, ever, so I just omitted logging from
the modules used directly by tools. Even without calling openlog()
first, every syslog() call goes to the logs.
But yeah, this should be handled smarter like setting a variable or
#defining something that tells it's OK to log..I'll propose another patch.
Thank you for the review,
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
-----END PGP SIGNATURE-----