Those 3 patches are from Jakub and I've just done some minor adjustments and add myself as co-author of the first 2 patches.
CI has passed: http://sssd-ci.duckdns.org/logs/job/51/55/summary.html
Best Regards, -- Fabiano Fidêncio
On Mon, Aug 15, 2016 at 02:58:50PM +0200, Fabiano Fidêncio wrote:
Those 3 patches are from Jakub and I've just done some minor adjustments and add myself as co-author of the first 2 patches.
CI has passed: http://sssd-ci.duckdns.org/logs/job/51/55/summary.html
Best Regards,
Fabiano Fidêncio
bump, this is just a simple removal of code, but I can't review it myself..
On 08/26/2016 04:59 PM, Jakub Hrozek wrote:
On Mon, Aug 15, 2016 at 02:58:50PM +0200, Fabiano Fidêncio wrote:
Those 3 patches are from Jakub and I've just done some minor adjustments and add myself as co-author of the first 2 patches.
CI has passed: http://sssd-ci.duckdns.org/logs/job/51/55/summary.html
Best Regards,
Fabiano Fidêncio
bump, this is just a simple removal of code, but I can't review it myself..
Hello Fabiano,
I will take a look. :-)
Regards
On 08/15/2016 02:58 PM, Fabiano Fidêncio wrote:
Those 3 patches are from Jakub and I've just done some minor adjustments and add myself as co-author of the first 2 patches.
CI has passed: http://sssd-ci.duckdns.org/logs/job/51/55/summary.html
Best Regards,
Fabiano Fidêncio
Hello,
CI passed: http://sssd-ci.duckdns.org/logs/job/52/71/summary.html
0001-MONITOR-Remove-the-no-longer-used-diag_cmd-command.patch
From aa6204816cde0a7d75b9303916d038ed06e467ba Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhrozek@redhat.com Date: Sun, 8 May 2016 14:41:35 +0200 Subject: [PATCH 1/3] MONITOR: Remove the no longer used diag_cmd command MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit
After introducing the watchdog, the diag_cmd is longer used and makes no sense trying to make it usable by watchdog as the result of "pstack %p" seems next to useless in this context.
Co-author: Fabiano Fidêncio fidencio@redhat.com
Related: https://fedorahosted.org/sssd/ticket/3051
ACK
0002-MONITOR-Remove-the-no-longer-used-kill_service-comma.patch
From 7954e0254752d0a830a0501f23a6a93d0345e5ce Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhrozek@redhat.com Date: Sun, 8 May 2016 14:46:25 +0200 Subject: [PATCH 2/3] MONITOR: Remove the no longer used kill_service command MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit
After introducing the watchdog, the force_timeout option is no longer used.
Co-author: Fabiano Fidêncio fidencio@redhat.com
Resolves: https://fedorahosted.org/sssd/ticket/3052
ACK
0003-WATCHDOG-define-and-use-_MAX_TICKS-as-3.patch
From 1302c5a95ac36dd674c8795cda0082b84d30978d Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhrozek@redhat.com Date: Mon, 15 Aug 2016 12:54:20 +0200 Subject: [PATCH 3/3] WATCHDOG: define and use _MAX_TICKS as 3
Instead of using the number 3 directly, let's introduce and use WATCHDOG_MAX_TICKS. --
This patch is unfortunately inapplicable on top of master (after two previous patches):
pcech@albireo ~/sssd: (master) $ git am ../patch/0003-WATCHDOG-define-and-use-_MAX_TICKS-as-3.patch Applying: WATCHDOG: define and use _MAX_TICKS as 3 error: patch failed: src/util/util_watchdog.c:38 error: src/util/util_watchdog.c: patch does not apply Patch failed at 0001 WATCHDOG: define and use _MAX_TICKS as 3
Regards
--- Petr^4 Čech
On Tue, Aug 30, 2016 at 8:23 AM, Petr Cech pcech@redhat.com wrote:
On 08/15/2016 02:58 PM, Fabiano Fidêncio wrote:
Those 3 patches are from Jakub and I've just done some minor adjustments and add myself as co-author of the first 2 patches.
CI has passed: http://sssd-ci.duckdns.org/logs/job/51/55/summary.html
Best Regards,
Fabiano Fidêncio
Hello,
CI passed: http://sssd-ci.duckdns.org/logs/job/52/71/summary.html
0001-MONITOR-Remove-the-no-longer-used-diag_cmd-command.patch
From aa6204816cde0a7d75b9303916d038ed06e467ba Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhrozek@redhat.com Date: Sun, 8 May 2016 14:41:35 +0200 Subject: [PATCH 1/3] MONITOR: Remove the no longer used diag_cmd command MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit
After introducing the watchdog, the diag_cmd is longer used and makes no sense trying to make it usable by watchdog as the result of "pstack %p" seems next to useless in this context.
Co-author: Fabiano Fidêncio fidencio@redhat.com
Related: https://fedorahosted.org/sssd/ticket/3051
ACK
0002-MONITOR-Remove-the-no-longer-used-kill_service-comma.patch
From 7954e0254752d0a830a0501f23a6a93d0345e5ce Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhrozek@redhat.com Date: Sun, 8 May 2016 14:46:25 +0200 Subject: [PATCH 2/3] MONITOR: Remove the no longer used kill_service command MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit
After introducing the watchdog, the force_timeout option is no longer used.
Co-author: Fabiano Fidêncio fidencio@redhat.com
Resolves: https://fedorahosted.org/sssd/ticket/3052
ACK
0003-WATCHDOG-define-and-use-_MAX_TICKS-as-3.patch
From 1302c5a95ac36dd674c8795cda0082b84d30978d Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhrozek@redhat.com Date: Mon, 15 Aug 2016 12:54:20 +0200 Subject: [PATCH 3/3] WATCHDOG: define and use _MAX_TICKS as 3
Instead of using the number 3 directly, let's introduce and use WATCHDOG_MAX_TICKS. --
This patch is unfortunately inapplicable on top of master (after two previous patches):
pcech@albireo ~/sssd: (master) $ git am ../patch/0003-WATCHDOG-define-and-use-_MAX_TICKS-as-3.patch Applying: WATCHDOG: define and use _MAX_TICKS as 3 error: patch failed: src/util/util_watchdog.c:38 error: src/util/util_watchdog.c: patch does not apply Patch failed at 0001 WATCHDOG: define and use _MAX_TICKS as 3
Regards
Rebase was quite simple. See the v2 attached (the only change in v2 was the rebase).
Petr^4 Čech _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
On 08/30/2016 08:28 AM, Fabiano Fidêncio wrote:
On Tue, Aug 30, 2016 at 8:23 AM, Petr Cech pcech@redhat.com wrote:
On 08/15/2016 02:58 PM, Fabiano Fidêncio wrote:
Those 3 patches are from Jakub and I've just done some minor adjustments and add myself as co-author of the first 2 patches.
CI has passed: http://sssd-ci.duckdns.org/logs/job/51/55/summary.html
Best Regards,
Fabiano Fidêncio
Hello,
CI passed: http://sssd-ci.duckdns.org/logs/job/52/71/summary.html
0001-MONITOR-Remove-the-no-longer-used-diag_cmd-command.patch
From aa6204816cde0a7d75b9303916d038ed06e467ba Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhrozek@redhat.com Date: Sun, 8 May 2016 14:41:35 +0200 Subject: [PATCH 1/3] MONITOR: Remove the no longer used diag_cmd command MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit
After introducing the watchdog, the diag_cmd is longer used and makes no sense trying to make it usable by watchdog as the result of "pstack %p" seems next to useless in this context.
Co-author: Fabiano Fidêncio fidencio@redhat.com
Related: https://fedorahosted.org/sssd/ticket/3051
ACK
0002-MONITOR-Remove-the-no-longer-used-kill_service-comma.patch
From 7954e0254752d0a830a0501f23a6a93d0345e5ce Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhrozek@redhat.com Date: Sun, 8 May 2016 14:46:25 +0200 Subject: [PATCH 2/3] MONITOR: Remove the no longer used kill_service command MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit
After introducing the watchdog, the force_timeout option is no longer used.
Co-author: Fabiano Fidêncio fidencio@redhat.com
Resolves: https://fedorahosted.org/sssd/ticket/3052
ACK
0003-WATCHDOG-define-and-use-_MAX_TICKS-as-3.patch
From 1302c5a95ac36dd674c8795cda0082b84d30978d Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhrozek@redhat.com Date: Mon, 15 Aug 2016 12:54:20 +0200 Subject: [PATCH 3/3] WATCHDOG: define and use _MAX_TICKS as 3
Instead of using the number 3 directly, let's introduce and use WATCHDOG_MAX_TICKS. --
This patch is unfortunately inapplicable on top of master (after two previous patches):
pcech@albireo ~/sssd: (master) $ git am ../patch/0003-WATCHDOG-define-and-use-_MAX_TICKS-as-3.patch Applying: WATCHDOG: define and use _MAX_TICKS as 3 error: patch failed: src/util/util_watchdog.c:38 error: src/util/util_watchdog.c: patch does not apply Patch failed at 0001 WATCHDOG: define and use _MAX_TICKS as 3
Regards
Rebase was quite simple. See the v2 attached (the only change in v2 was the rebase).
Thanks, Fabiano,
I pushed patches to CI so quickly I missed that the 3rd patch is LGTM and almost ACK :-)
I would like to wait to CI anyway.
Regards
On 08/30/2016 08:47 AM, Petr Cech wrote:
On 08/30/2016 08:28 AM, Fabiano Fidêncio wrote:
On Tue, Aug 30, 2016 at 8:23 AM, Petr Cech pcech@redhat.com wrote:
On 08/15/2016 02:58 PM, Fabiano Fidêncio wrote:
Those 3 patches are from Jakub and I've just done some minor adjustments and add myself as co-author of the first 2 patches.
CI has passed: http://sssd-ci.duckdns.org/logs/job/51/55/summary.html
Best Regards,
Fabiano Fidêncio
Hello,
CI passed: http://sssd-ci.duckdns.org/logs/job/52/71/summary.html
0001-MONITOR-Remove-the-no-longer-used-diag_cmd-command.patch
From aa6204816cde0a7d75b9303916d038ed06e467ba Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhrozek@redhat.com Date: Sun, 8 May 2016 14:41:35 +0200 Subject: [PATCH 1/3] MONITOR: Remove the no longer used diag_cmd command MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit
After introducing the watchdog, the diag_cmd is longer used and makes no sense trying to make it usable by watchdog as the result of "pstack %p" seems next to useless in this context.
Co-author: Fabiano Fidêncio fidencio@redhat.com
Related: https://fedorahosted.org/sssd/ticket/3051
ACK
0002-MONITOR-Remove-the-no-longer-used-kill_service-comma.patch
From 7954e0254752d0a830a0501f23a6a93d0345e5ce Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhrozek@redhat.com Date: Sun, 8 May 2016 14:46:25 +0200 Subject: [PATCH 2/3] MONITOR: Remove the no longer used kill_service command MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit
After introducing the watchdog, the force_timeout option is no longer used.
Co-author: Fabiano Fidêncio fidencio@redhat.com
Resolves: https://fedorahosted.org/sssd/ticket/3052
ACK
0003-WATCHDOG-define-and-use-_MAX_TICKS-as-3.patch
From 1302c5a95ac36dd674c8795cda0082b84d30978d Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhrozek@redhat.com Date: Mon, 15 Aug 2016 12:54:20 +0200 Subject: [PATCH 3/3] WATCHDOG: define and use _MAX_TICKS as 3
Instead of using the number 3 directly, let's introduce and use WATCHDOG_MAX_TICKS. --
This patch is unfortunately inapplicable on top of master (after two previous patches):
pcech@albireo ~/sssd: (master) $ git am ../patch/0003-WATCHDOG-define-and-use-_MAX_TICKS-as-3.patch Applying: WATCHDOG: define and use _MAX_TICKS as 3 error: patch failed: src/util/util_watchdog.c:38 error: src/util/util_watchdog.c: patch does not apply Patch failed at 0001 WATCHDOG: define and use _MAX_TICKS as 3
Regards
Rebase was quite simple. See the v2 attached (the only change in v2 was the rebase).
Thanks, Fabiano,
I pushed patches to CI so quickly I missed that the 3rd patch is LGTM and almost ACK :-)
I would like to wait to CI anyway.
CI passed: http://sssd-ci.duckdns.org/logs/job/52/73/summary.html
=> ACK
Regards
On (30/08/16 09:41), Petr Cech wrote:
On 08/30/2016 08:47 AM, Petr Cech wrote:
On 08/30/2016 08:28 AM, Fabiano Fidêncio wrote:
On Tue, Aug 30, 2016 at 8:23 AM, Petr Cech pcech@redhat.com wrote:
On 08/15/2016 02:58 PM, Fabiano Fidêncio wrote:
Those 3 patches are from Jakub and I've just done some minor adjustments and add myself as co-author of the first 2 patches.
CI has passed: http://sssd-ci.duckdns.org/logs/job/51/55/summary.html
Best Regards,
Fabiano Fidêncio
Hello,
CI passed: http://sssd-ci.duckdns.org/logs/job/52/71/summary.html
0001-MONITOR-Remove-the-no-longer-used-diag_cmd-command.patch
From aa6204816cde0a7d75b9303916d038ed06e467ba Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhrozek@redhat.com Date: Sun, 8 May 2016 14:41:35 +0200 Subject: [PATCH 1/3] MONITOR: Remove the no longer used diag_cmd command MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit
After introducing the watchdog, the diag_cmd is longer used and makes no sense trying to make it usable by watchdog as the result of "pstack %p" seems next to useless in this context.
Co-author: Fabiano Fidêncio fidencio@redhat.com
Related: https://fedorahosted.org/sssd/ticket/3051
ACK
0002-MONITOR-Remove-the-no-longer-used-kill_service-comma.patch
From 7954e0254752d0a830a0501f23a6a93d0345e5ce Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhrozek@redhat.com Date: Sun, 8 May 2016 14:46:25 +0200 Subject: [PATCH 2/3] MONITOR: Remove the no longer used kill_service command MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit
After introducing the watchdog, the force_timeout option is no longer used.
Co-author: Fabiano Fidêncio fidencio@redhat.com
Resolves: https://fedorahosted.org/sssd/ticket/3052
ACK
0003-WATCHDOG-define-and-use-_MAX_TICKS-as-3.patch
From 1302c5a95ac36dd674c8795cda0082b84d30978d Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhrozek@redhat.com Date: Mon, 15 Aug 2016 12:54:20 +0200 Subject: [PATCH 3/3] WATCHDOG: define and use _MAX_TICKS as 3
Instead of using the number 3 directly, let's introduce and use WATCHDOG_MAX_TICKS. --
This patch is unfortunately inapplicable on top of master (after two previous patches):
pcech@albireo ~/sssd: (master) $ git am ../patch/0003-WATCHDOG-define-and-use-_MAX_TICKS-as-3.patch Applying: WATCHDOG: define and use _MAX_TICKS as 3 error: patch failed: src/util/util_watchdog.c:38 error: src/util/util_watchdog.c: patch does not apply Patch failed at 0001 WATCHDOG: define and use _MAX_TICKS as 3
Regards
Rebase was quite simple. See the v2 attached (the only change in v2 was the rebase).
Thanks, Fabiano,
I pushed patches to CI so quickly I missed that the 3rd patch is LGTM and almost ACK :-)
I would like to wait to CI anyway.
CI passed: http://sssd-ci.duckdns.org/logs/job/52/73/summary.html
=> ACK
master: * d7075a255a1f28e890539072e06d0140ffe0927c * fa93cd0f0fc75a6d635079e67788f8a9fe183c3c * 1620f435dbe7013f985128dcdf001e9158cb00e3
LS
sssd-devel@lists.fedorahosted.org