On 10/03/2012 04:42 PM, Jakub Hrozek wrote:
On Wed, Oct 03, 2012 at 03:25:46PM +0200, Michal Židek wrote:
> On 10/03/2012 03:09 PM, Ondrej Kos wrote:
>> On 10/03/2012 01:56 PM, Ondrej Kos wrote:
>>> On 10/03/2012 01:48 PM, Ondrej Kos wrote:
>>>> On 10/02/2012 07:03 PM, Ondrej Kos wrote:
>>>>> fixes
https://fedorahosted.org/sssd/ticket/1533
>>>>>
>>>>> ccache file template is now checked for appended XXXXXX for use with
>>>>> mkstemp. When those characters are not present, warning is written
to
>>>>> log.
>>>>>
>>>>> patch is attached
>>>>>
>>>>> O.
>>>>>
>>>> self NACK
>>>>
>>>> We discussed it with Michal off-list and found that comparison was
>>>> faulty - taken from krb5_auth code, so fixed there as well. Also i
>>>> changed headers of affected functions not to pass so many (futile)
>>>> arguments. new patch attached.
>>>>
>>>> O.
>>>>
>>> self NACK again, Michal confused me! code in krb5_child was ok, so
>>> working patch attached.
>>>
>> Another off-list discussion, faulty condition.
>> new patch attached
>>
>> O.
>>
>>
>
> Looks good to me now.
>
> ACK.
>
> Michal
I'd like to see two more changes:
1) Don't pass the whole krb5child_req structure to
cc_be_check_existing(), it's enough to just pass the option value or
if we needed more options the whole options structure.
As we discussed it with Michal, we decided to pass whole structure,
since we're using three of its members now, but no problem, changed.
2) Rename the function from cc_file_check_template to something
that
doesn't include _file_ and make it static.
done
fixed patch attached
O.
--
Ondrej Kos
Associate Software Engineer
Identity Management
Red Hat Czech
phone: +420-532-294-558
cell: +420-736-417-909
ext: 82-62558
loc: 1/5C Brno office
irc: okos @ #brno