URL: https://github.com/SSSD/sssd/pull/5432 Author: pbrezina Title: #5432: kcm: decode base64 encoded secret on upgrade path Action: opened
PR body: """ Previous unefficient code encoded the secret multiple times: secret -> base64 -> masterkey -> base64
To allow smooth upgrade for already existant ccache we need to also decode the secret if it is still in the old format (type == simple). Otherwise users are not able to log in.
Resolves: https://github.com/SSSD/sssd/issues/5349
To test, build SSSD without recent KCM performance patches. Run SSSD, login as a Kerberized user to create ccache and log out.
Then apply the patches, and rebuild. Make sure to restart sssd-kcm. Try to log in - it should fail.
Apply this patch - the login should succeed. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5432/head:pr5432 git checkout pr5432
URL: https://github.com/SSSD/sssd/pull/5432 Title: #5432: kcm: decode base64 encoded secret on upgrade path
pbrezina commented: """ @alexey-tikhonov Apparently, nobody actually tested the upgrade path before our [users](https://bodhi.fedoraproject.org/updates/FEDORA-2020-075cc71cb8). Would you mind to review this so I can include it in new Fedora build? """
See the full comment at https://github.com/SSSD/sssd/pull/5432#issuecomment-741761811
URL: https://github.com/SSSD/sssd/pull/5432 Title: #5432: kcm: decode base64 encoded secret on upgrade path
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/5432 Title: #5432: kcm: decode base64 encoded secret on upgrade path
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/5432 Author: pbrezina Title: #5432: kcm: decode base64 encoded secret on upgrade path Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5432/head:pr5432 git checkout pr5432
URL: https://github.com/SSSD/sssd/pull/5432 Title: #5432: kcm: decode base64 encoded secret on upgrade path
alexey-tikhonov commented: """ ACK """
See the full comment at https://github.com/SSSD/sssd/pull/5432#issuecomment-742498192
URL: https://github.com/SSSD/sssd/pull/5432 Title: #5432: kcm: decode base64 encoded secret on upgrade path
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/5432 Title: #5432: kcm: decode base64 encoded secret on upgrade path
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/5432 Title: #5432: kcm: decode base64 encoded secret on upgrade path
pbrezina commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5432
* `master` * 18b98836ef8e337992f0ecb239a32b9c3cedb750 - kcm: decode base64 encoded secret on upgrade path
"""
See the full comment at https://github.com/SSSD/sssd/pull/5432#issuecomment-743083681
URL: https://github.com/SSSD/sssd/pull/5432 Title: #5432: kcm: decode base64 encoded secret on upgrade path
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/5432 Title: #5432: kcm: decode base64 encoded secret on upgrade path
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/5432 Title: #5432: kcm: decode base64 encoded secret on upgrade path
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/5432 Author: pbrezina Title: #5432: kcm: decode base64 encoded secret on upgrade path Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5432/head:pr5432 git checkout pr5432
sssd-devel@lists.fedorahosted.org