On (20/11/15 12:03), Jakub Hrozek wrote:
I already marked the defect in our static analyzer as a false
positive,
but maybe it's better to write code that doesn't confuse static
analyzers in the first place..
From b85c9c3771d0a4d4daf51b7ca8b4093236588395 Mon Sep 17 00:00:00
2001
From: Jakub Hrozek <jhrozek(a)redhat.com>
Date: Fri, 20 Nov 2015 11:32:48 +0100
Subject: [PATCH] DP: Do not confuse static analysers with dead code
---
src/providers/data_provider_be.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/providers/data_provider_be.c b/src/providers/data_provider_be.c
index 0580c799cd8ba4d6348612f47f51775a1f6bff5c..1d37e4d334a6fa5deb80703b2840b6aec8231a23
100644
--- a/src/providers/data_provider_be.c
+++ b/src/providers/data_provider_be.c
@@ -126,8 +126,9 @@ static const char *dp_err_to_string(int dp_err_type)
case DP_ERR_TIMEOUT:
return "Request timed out";
case DP_ERR_FATAL:
- default:
return "Internal Error";
+ default:
+ break;
}
return "Unknown Error";
--
Fixed defects
Error: UNREACHABLE (CWE-561): [#def1]
sssd-1.13.90/src/providers/data_provider_be.c:133:
unreachable: This code cannot be reached:
"return "Unknown Error";".
# 131| }
# 132|
# 133|-> return "Unknown Error";
# 134| }
# 135|
ACK
LS