-----BEGIN PGP SIGNED MESSAGE-----
On 06/01/2014 04:09 PM, Jakub Hrozek wrote:
On Fri, May 30, 2014 at 06:04:01PM +0200, Pavel Reichl wrote:
> OK, please see updated patch. PR
Thank you, from content point of view, this looks correct to me.
Can you please ping some native English speaker before I push the
patch? There are two parts below that I'm not sure about, but as I
said, it's not about content, just ironing out the language.
> @@ -1776,7 +1776,14 @@ users being denied access. Use
> access_provider = permit to change this default behavior. Please
> note that this filter is applied on -
> the LDAP user entry only. + the LDAP
> user entry only and thus filtering based +
> on nested groups may not work (e.g. memberOf +
> attribute on AD entries points only on direct
"points only *to* direct parents"
> + parents). If nested group based
> filtering is + desired please see
"If filtering based on nested groups is required, please see"
Maybe required instead of desired?
> + <citerefentry> +
> </para> <para> Example: diff --git
> b/src/man/sssd-simple.5.xml index
> 100644 --- a/src/man/sssd-simple.5.xml +++
> b/src/man/sssd-simple.5.xml @@ -144,6 +144,18 @@ </para>
> + <refsect1 id='notes'> + <title>NOTES</title> +
> <para> + The complete group memberships are resolved
> before the access check,
I'm not sure if "group memberships are" should read "group
membership is", iow if it's better to use singular or plural
"The complete group membership hierarchy is resolved before the access
check, thus even nested groups..."
> + so even nested groups can be included in the access
> lists. Please be + aware of ldap_group_nesting_level
"Please be aware that the 'ldap_group_nesting_level' option may impact
the results and should be set to a sufficient value."
> + (<citerefentry> +
> + </citerefentry>) option. + </para> +
> </refsect1> + <xi:include
> href="include/seealso.xml" />
> </refentry> -- 220.127.116.11
_______________________________________________ sssd-devel mailing
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
-----END PGP SIGNATURE-----